[CI]: bump travis timeout for make check to 50m #12772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK bc308ba with my rationale copied from #10267 (comment) I am fine with bumping to 40 or 50 minutes. In case we need that much time, it will time out due to the global limit anyway. The long term solution would be to somehow speed up the unit tests on Wine, but that doesn't have to block this (and other) pull requests. |
Contributor
|
utACK bc308ba |
1 similar comment
Member
|
utACK bc308ba |
maflcko
pushed a commit
that referenced
this pull request
Mar 24, 2018
bc308ba [CI]: bump travis timeout for make check to 50m (Karl-Johan Alm) Pull request description: The travis windows build sometimes times out on `make check`. Bump the timeout from 20 to 50 minutes. This is a short-term measure. We should figure out why the unit tests are slow in Wine. Tree-SHA512: 4a512e96b805d52ea25eebb5dc026a11c48392abbc5d70990698ab44fae1494ec67261515948a7a8f919669716614817464c059e54d3beb99487358387f79a17
Contributor
|
The windows build still seems to be timing out, examples: https://travis-ci.org/bitcoin/bitcoin/jobs/363172751#L2758 Maybe it would be a good idea to temporarily disable these checks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The travis windows build sometimes times out on
make check. Bump the timeout from 20 to 50 minutes.This is a short-term measure. We should figure out why the unit tests are slow in Wine.