[Tests] Tidy up REST interface functional tests #12766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@jnewbery Please let me know what else could be improved in the tests :) |
394551c to
a3d0946
Compare
Contributor
|
Will review after #12717 is merged (feel free to ping me again once that happens!) |
Member
It's merged, please rebase (so that this is only test changes). |
5d42265 to
dcefc24
Compare
dcefc24 to
d54e3e7
Compare
Contributor
Author
|
@jnewbery Ping :) |
jnewbery
reviewed
Apr 2, 2018
Contributor
jnewbery
left a comment
There was a problem hiding this comment.
Tested ACK d54e3e704838eb39a5e6e33d8b530c6ed404fd49. One comment inline.
Commits can probably be squashed a bit before merge. Feel free to take my changes without the commit messages if that makes things more structured.
test/functional/interface_rest.py
Outdated
Contributor
There was a problem hiding this comment.
I'm not sure if ordering is guaranteed here. Perhaps construct sets and check for set equality?
d54e3e7 to
7304c0b
Compare
Also refactor txout index parsing and formatting.
We use assert_greater_than_or_equal(), since the hex response contains an extra b'\n' traling byte.
7304c0b to
55efc1f
Compare
Contributor
Author
Squashed most of the small commits into a few large ones. |
Contributor
|
Tested ACK 55efc1f. Nicely structured PR. Very easy to review! Thanks |
Member
|
utACK 55efc1f |
laanwj
added a commit
that referenced
this pull request
Apr 7, 2018
55efc1f [tests] simplify binary and hex response parsing in interface_rest.py (Roman Zeyde) ade5964 [tests] only use 2 nodes in interface_rest.py (John Newbery) ad00fbe [tests] refactor interface_rest.py to avoid code repetition (John Newbery) 7a3181a [tests] Make json request building more consistent in interface_rest.py (John Newbery) 3fd4490 [tests] improve logging and documentation in interface_rest.py (John Newbery) abf190e [tests] fix flake8 warnings in interface_rest.py test (John Newbery) Pull request description: Following the comment at #12717 (review). Tree-SHA512: b55560f0d8f3069584f5a2398285483a0a23514b2b2bd2c1ced2db1cb30dc24f60f720d0fa4de30259f7918d3178d94680ae9321649544d1d04d687a2e672559
UdjinM6
pushed a commit
to UdjinM6/dash
that referenced
this pull request
May 22, 2021
55efc1f [tests] simplify binary and hex response parsing in interface_rest.py (Roman Zeyde) ade5964 [tests] only use 2 nodes in interface_rest.py (John Newbery) ad00fbe [tests] refactor interface_rest.py to avoid code repetition (John Newbery) 7a3181a [tests] Make json request building more consistent in interface_rest.py (John Newbery) 3fd4490 [tests] improve logging and documentation in interface_rest.py (John Newbery) abf190e [tests] fix flake8 warnings in interface_rest.py test (John Newbery) Pull request description: Following the comment at bitcoin#12717 (review). Tree-SHA512: b55560f0d8f3069584f5a2398285483a0a23514b2b2bd2c1ced2db1cb30dc24f60f720d0fa4de30259f7918d3178d94680ae9321649544d1d04d687a2e672559
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the comment at #12717 (review).