Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) #12168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Rationale: compiling on musl-based system (Alpine Linux for example) produces warnings. It just should be without |
Member
|
utACK 648bdc8 |
theuni
approved these changes
Jan 12, 2018
Member
theuni
left a comment
There was a problem hiding this comment.
Heh, I have the same commit queued up locally from testing with musl this week.
I believe there are some ancient OSs that may only have the sys/fcntl.h version, but I'm ok with not adding detection until someone complains about an actual failed build.
utACK 648bdc8
Member
|
utACK 648bdc8 |
maflcko
pushed a commit
that referenced
this pull request
Jan 13, 2018
…out sys/) 648bdc8 Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (Jan Sarenik) Pull request description: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html Tree-SHA512: 82c7e0aba55f34a6fec60bdecb712b65c84422461454f0ae9eed5e1bb31bf585c5a65f49bbdd5a89feb59140a998ad6fcd5573ede123a12b2ba2ff677d95cc2b
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 31, 2020
…h (without sys/) 648bdc8 Trivial: Fix #include sys/fcntl.h to just fcntl.h (without sys/) (Jan Sarenik) Pull request description: http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html http://man7.org/linux/man-pages/man2/fcntl.2.html Tree-SHA512: 82c7e0aba55f34a6fec60bdecb712b65c84422461454f0ae9eed5e1bb31bf585c5a65f49bbdd5a89feb59140a998ad6fcd5573ede123a12b2ba2ff677d95cc2b
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://pubs.opengroup.org/onlinepubs/009695399/functions/fcntl.html
http://man7.org/linux/man-pages/man2/fcntl.2.html