Remove dead store in ecdsa_signature_parse_der_lax. #11073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was one of the issues found by Clang's static analyzer (bitcoin#9573).
Member
|
Yes, that assignment is unnecessary. |
Contributor
|
utACK bfebc0b @BitonicEelis Nice first-time contribution! 👍 Please keep it coming! :-) |
Contributor
Author
|
@practicalswift Thanks! I plan to. :) |
Contributor
|
utACK bfebc0b. |
Member
|
@sipa can you take a look here just to be sure that not using |
Member
|
Ping @sipa |
Member
|
utACK bfebc0b |
sipa
approved these changes
Oct 12, 2017
laanwj
added a commit
that referenced
this pull request
Oct 12, 2017
bfebc0b Remove dead store in ecdsa_signature_parse_der_lax. (Eelis) Pull request description: This was one of the issues found by Clang's static analyzer (#9573). Tree-SHA512: 3674c56ccdc750bfe42e41d56b1f2058b6921c5354f7e757f6af10a759c5be75e23d6c7932a4524b9a24da308f426803b11deffbfcf09a5898a4204ee61d16d2
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jan 12, 2020
bfebc0b Remove dead store in ecdsa_signature_parse_der_lax. (Eelis) Pull request description: This was one of the issues found by Clang's static analyzer (bitcoin#9573). Tree-SHA512: 3674c56ccdc750bfe42e41d56b1f2058b6921c5354f7e757f6af10a759c5be75e23d6c7932a4524b9a24da308f426803b11deffbfcf09a5898a4204ee61d16d2
fanquake
added a commit
to fanquake/secp256k1
that referenced
this pull request
Jun 29, 2020
This change was made in bitcoin/bitcoin without upstreaming. So this is a followup to the comment here: bitcoin/bitcoin#19228 (comment). See also: bitcoin/bitcoin#11073.
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Sep 27, 2020
Summary: This change was made in bitcoin/bitcoin without upstreaming. So this is a followup to the comment here: bitcoin/bitcoin#19228 (comment). See also: bitcoin/bitcoin#11073. This is a backport of libsecp256k1 [[bitcoin-core/secp256k1#765 | PR765]] Test Plan: ninja check-secp256k1 Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D7592
deadalnix
pushed a commit
to Bitcoin-ABC/secp256k1
that referenced
this pull request
Sep 28, 2020
Summary: This change was made in bitcoin/bitcoin without upstreaming. So this is a followup to the comment here: bitcoin/bitcoin#19228 (comment). See also: bitcoin/bitcoin#11073. This is a backport of libsecp256k1 [[bitcoin-core/secp256k1#765 | PR765]] Test Plan: ninja check-secp256k1 Reviewers: #bitcoin_abc, majcosta Reviewed By: #bitcoin_abc, majcosta Differential Revision: https://reviews.bitcoinabc.org/D7592
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was one of the issues found by Clang's static analyzer (#9573).