random: only use getentropy on openbsd #10855
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
utACK 077d01f |
Contributor
|
utACK 077d01f |
Contributor
|
utACK 077d01f |
laanwj
added a commit
that referenced
this pull request
Jul 18, 2017
077d01f random: only use getentropy on openbsd (Cory Fields) Pull request description: Follow-up from #10335. I can confirm that this fixes my issue when building against a new glibc + old linux headers for back-compat. Tree-SHA512: a0fcf26995fbd3636f970e729a172c6e1d7c0de371e703f0653cd9776600f438ec43acd2b1eb92f2678a011968da8fbbeef8a54599434851f4c6ffe78291c172
Member
|
Tested on OpenBSD that getentropy() is still used. ACK 077d01f |
| /* On OpenBSD this can return up to 256 bytes of entropy, will return an | ||
| * error if more are requested. | ||
| * The call cannot return less than the requested number of bytes. | ||
| getentropy is explicitly limited to openbsd here, as a similar (but not |
Contributor
There was a problem hiding this comment.
OSX also needs getentropy.
Member
Author
There was a problem hiding this comment.
hmm? I don't see any reference for that. Afaik everything for osx is just a wrapper around /dev/[u]random anyway.
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 24, 2019
077d01f random: only use getentropy on openbsd (Cory Fields) Pull request description: Follow-up from bitcoin#10335. I can confirm that this fixes my issue when building against a new glibc + old linux headers for back-compat. Tree-SHA512: a0fcf26995fbd3636f970e729a172c6e1d7c0de371e703f0653cd9776600f438ec43acd2b1eb92f2678a011968da8fbbeef8a54599434851f4c6ffe78291c172
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from #10335. I can confirm that this fixes my issue when building against a new glibc + old linux headers for back-compat.