-
Notifications
You must be signed in to change notification settings - Fork 38.7k
depends: fix fontconfig with newer glibc #10851
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Sounds fine to me. |
|
This fails to build for me with this warning: It looks like travis failed with the same error Installing gperf results in this error: |
|
grr! Upstream borked this. I'll just cherry-pick the patch into our current version instead. |
|
Hehe, that's what you get when you say "fixes build", you get reports of new build problems. More seriously: this is only used for linking against, right? does raising the fontconfig version raise the minimum fontconfig version requires on the user's system? (by changing the ABI) |
|
@laanwj Yes, this is only for linking against. That's a good question. We should make sure to check before bumping. |
|
Gitian build errors: Linux: |
|
This seems more trouble than it's worth for 0.15. Could we maybe backport just the build fix for gcc6/7? |
|
This should also be backported to 0.14.3. |
|
Not in the current state at least... |
|
@laanwj Yes, will do that today. |
See comment for more detail
|
Travis is a timeout, and probably unrelated, respinning |
|
Can confirm that 3498a8d compiles on gcc7.1.1 |
|
Changed the PR title to reflect what the commit does :) |
3498a8d depends: fix fontconfig with newer glibc (Cory Fields) Pull request description: Fixes build with newer gcc. Without this, depends builds fail with gcc7, maybe gcc6. Tree-SHA512: 3cfcebdb137c3e368c69d25012ceb32809890e67521aaa8b074f2092f847e3e7ae82ac9050b4600ba18f443d2a8fe1f8523c808d77642a1e7782d558cbad4a74
3498a8d depends: fix fontconfig with newer glibc (Cory Fields) Pull request description: Fixes build with newer gcc. Without this, depends builds fail with gcc7, maybe gcc6. Tree-SHA512: 3cfcebdb137c3e368c69d25012ceb32809890e67521aaa8b074f2092f847e3e7ae82ac9050b4600ba18f443d2a8fe1f8523c808d77642a1e7782d558cbad4a74
3498a8d depends: fix fontconfig with newer glibc (Cory Fields) Pull request description: Fixes build with newer gcc. Without this, depends builds fail with gcc7, maybe gcc6. Tree-SHA512: 3cfcebdb137c3e368c69d25012ceb32809890e67521aaa8b074f2092f847e3e7ae82ac9050b4600ba18f443d2a8fe1f8523c808d77642a1e7782d558cbad4a74
Fixes build with newer gcc.
Without this, depends builds fail with gcc7, maybe gcc6.