Fix incorrect Doxygen tag (@ince → @since). Doxygen parameter name matching. #10842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
trivial ACK 8a2e5b1 |
Contributor
Author
|
@fanquake Thanks for the quick review. I added another commit to this PR (be9682d). Would you mind re-reviewing? :-) |
src/wallet/rpcwallet.h
Outdated
Contributor
There was a problem hiding this comment.
Why did you change this one and not the ones below it?
Contributor
There was a problem hiding this comment.
Oh don't worry you're just focusing on doxygen, sorry missed that
Contributor
Author
There was a problem hiding this comment.
They don't have any Doxygen documentation to match :-)
Member
|
Please squash when this is ready for merge.
…On Sun, Jul 16, 2017 at 12:24 PM, fanquake ***@***.***> wrote:
trivial ACK 8a2e5b1
<8a2e5b1>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10842 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGGmv1SEZLXxV9xK8bWqVfLoKQ0AgZ8Eks5sOeT2gaJpZM4OZQc->
.
|
…mes match actual parameter names.
be9682d to
2c2e90d
Compare
Contributor
Author
|
@MarcoFalke Squashed! :-) |
Member
|
utACK 2c2e90d |
maflcko
pushed a commit
that referenced
this pull request
Jul 16, 2017
…ameter name matching. 2c2e90d Fix incorrect Doxygen tag (@ince → @SInCE). Make Doxygen parameter names match actual parameter names. (practicalswift) Pull request description: Doxygen fixes: * Fix incorrect Doxygen tag (`@ince` → `@since`). * Make Doxygen parameter names match actual parameter names. Tree-SHA512: cb1d37a7d15a90d24affaf5c2bcf462663f0b0c13868bb25401e5d8cb303fcb41e53fdeee8012b2271a509112ef98fc0c070b4194f42cd55361f7e6bc7996342
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
Jul 24, 2019
…gen parameter name matching. 2c2e90d Fix incorrect Doxygen tag (@ince → @SInCE). Make Doxygen parameter names match actual parameter names. (practicalswift) Pull request description: Doxygen fixes: * Fix incorrect Doxygen tag (`@ince` → `@since`). * Make Doxygen parameter names match actual parameter names. Tree-SHA512: cb1d37a7d15a90d24affaf5c2bcf462663f0b0c13868bb25401e5d8cb303fcb41e53fdeee8012b2271a509112ef98fc0c070b4194f42cd55361f7e6bc7996342
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 7, 2020
…parameter name matching. Summary: 2c2e90d Fix incorrect Doxygen tag (@ince → @SInCE). Make Doxygen parameter names match actual parameter names. (practicalswift) Pull request description: Doxygen fixes: * Fix incorrect Doxygen tag (`@ince` → `@since`). * Make Doxygen parameter names match actual parameter names. --- Backport of Core [[bitcoin/bitcoin#10842 | PR10842]] Test Plan: read the comment changes Reviewers: #bitcoin_abc, jasonbcox Reviewed By: #bitcoin_abc, jasonbcox Differential Revision: https://reviews.bitcoinabc.org/D7789
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doxygen fixes:
@ince→@since).