Skip to content

Conversation

@genjix
Copy link

@genjix genjix commented Mar 8, 2011

Intelligent run script. Selects correct architecture (64 bit or 32 bit) and runs the right version of Bitcoin.
Should be placed in the top level dir during release.

Added in argument passing. I closed old pull request, #104

See http://www.bitcoin.org/smf/index.php?topic=3904.0

I think for release you should offer 2 downloads (like Ubuntu does):
The default Linux release marked as 'Bitcoin (Recommended)' and the 64 bit version 'Bitcoin 64 bit'. Nice and simple. So feel free to close this pull request as long as dual release packages are agreed upon.

Put bitcoin in the top level directory. Hide bitcoind in a subdirectory. The current release layout is very confusing for new users.

@jgarzik
Copy link
Contributor

jgarzik commented Mar 9, 2011

Same comments as with #104

I agree with the recommendation about bitcoin (recommended) and bitcoin (64-bit). Maybe open an issue for that?

@jgarzik
Copy link
Contributor

jgarzik commented Mar 10, 2011

Things are fine as-is

dexX7 pushed a commit to dexX7/bitcoin that referenced this pull request Sep 3, 2014
Fix strToInt64 function and add unit tests
glv2 referenced this pull request in glv2/peercoin Sep 4, 2014
rdponticelli pushed a commit to Criptomonedas/bitcoin that referenced this pull request Nov 26, 2014
f49b2ef Add DETERMINISTIC to avoid line number/source dependent binaries (Pieter Wuille)
dexX7 added a commit to dexX7/bitcoin that referenced this pull request Jul 3, 2015
f35fb80 Avoid using variable length array in parseTransaction() (dexX7)
TheBlueMatt pushed a commit to TheBlueMatt/bitcoin that referenced this pull request Oct 3, 2016
…rmonize_unittest_names

Harmonize unit test suite names with filenames
classesjack pushed a commit to classesjack/bitcoin that referenced this pull request Jan 2, 2018
Gas refunds appear to not be correctly issued when the number of txs that include op_call or op_create > 1 (Qtum Core / issue#106)
cryptapus added a commit to cryptapus/bitcoin that referenced this pull request Sep 11, 2018
lateminer pushed a commit to lateminer/bitcoin that referenced this pull request Feb 23, 2019
Reverted alternate protocol enforcement spork
Losangelosgenetics pushed a commit to Losangelosgenetics/bitcoin that referenced this pull request Mar 12, 2020
jonasschnelli added a commit that referenced this pull request Oct 27, 2020
… window without loaded wallets

7b2e42e qt: Add WalletFrame::sizeHint (Hennadii Stepanov)

Pull request description:

  This PR fixes a bug in master (d67883d) and in 0.20.1 that could be easily reproduced with
  ```
  $ src/qt/bitcoin-qt -regtest -resetguisettings -nowallet
  ```

  ![Screenshot from 2020-10-25 21-21-27](https://user-images.githubusercontent.com/32963518/97117179-b1800100-170a-11eb-87c9-3120d39b9455.png)
  ![Screenshot from 2020-10-25 21-23-32](https://user-images.githubusercontent.com/32963518/97117186-b644b500-170a-11eb-8b5d-234ff7205003.png)

  **With this PR:**

  ![Screenshot from 2020-10-25 21-20-35](https://user-images.githubusercontent.com/32963518/97117226-f441d900-170a-11eb-8d66-98b7718a2bb1.png)
  ![Screenshot from 2020-10-25 21-23-03](https://user-images.githubusercontent.com/32963518/97117232-f99f2380-170a-11eb-85ed-c7b5ece926b2.png)

  ---

  Fix #104
  Fix #113

  This PR is an alternative to #107 without [hard-coding a size in pixels](bitcoin-core/gui#107 (comment)).

ACKs for top commit:
  jonasschnelli:
    Tested ACK 7b2e42e - I can confirm this fixes #104 (Ubuntu 20.04 - HiDPI 200%).

Tree-SHA512: eb0692dbeb3befdeecca0e41534c9783eab6637c14cc4f170ee42619235884f9354f8d22a10c20c08cc89dc5340a60b7dfa2523c12e64b3386b3fd2c6d5f934e
rajarshimaitra pushed a commit to rajarshimaitra/bitcoin that referenced this pull request Mar 23, 2021
RGB: hashing bulletproof commitments; closes bitcoin#106
rajarshimaitra pushed a commit to rajarshimaitra/bitcoin that referenced this pull request Aug 5, 2021
Wrote "Motivation for the Lightning Network" and "Lightning Network Basic Concepts" in Chapter 1
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants