Skip to content

[trivial] Fix three recently introduced typos #10419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sipa merged 1 commit into from
May 26, 2017
Merged

[trivial] Fix three recently introduced typos #10419

sipa merged 1 commit into from
May 26, 2017

Conversation

@practicalswift
Copy link
Contributor

@practicalswift practicalswift commented May 18, 2017 •
edited
Loading

Typos introduced in 3810e97 and 2d2e170 which were merged into master as part of #10199 twelve hours ago:

$ git blame src/policy/fees.cpp | grep becuase
3810e976 (2017-03-07 11:33:44 -0500 789)          * checks for 2*target becuase we are taking the max over all time
$ git blame src/policy/fees.h | grep successfullly
2d2e1705 (2017-04-12 12:29:03 -0400  54)  * representing that a tx was successfullly confirmed in less than or equal to

Friendly ping @morcos :-)

@paveljanik
Copy link
Contributor

paveljanik commented May 18, 2017

ACK 6516a9f

@fanquake
Copy link
Member

fanquake commented May 18, 2017

trivial ACK 6516a9f

Im curious. What tool are you using to find these? I assume it's being run in some automated way on the repository when new changes are merged? Why not merge the open pull requests instead, catch the typos/incorrect includes etc etc and then advise changes in the PRs while they are still open?

@fanquake fanquake added the Docs label May 18, 2017
@practicalswift
Copy link
Contributor Author

practicalswift commented May 18, 2017 •
edited
Loading

@fanquake I've written a bunch of custom scripts that help me identify potential issues. These cover the spectra from identifying trivial typos to running and triaging output from clang-tidy and similar tools. However, the cleanup work is all manual. See my gardening efforts in the Apple Swift project for examples of issues covered by my gardening toolkit.

For various reasons the Swift project is a bit more strict (i.e. near zero tolerance towards clang-tidy violations, full PEP-8 compliance, etc.), so I'm using a more relaxed subset of the same toolkit when gardening the Bitcoin project :-)

Unfortunately the toolkit work flow does not yet support checking not-yet-merged pull requests easily, but that is something I would like to add in the future :-)

@morcos
Copy link
Contributor

morcos commented May 18, 2017

(sigh at myself) ACK

@jtimon
Copy link
Contributor

jtimon commented May 22, 2017 •
edited
Loading

ACK 6516a9fcb1f0190564fba4b24837c5942ed5788a

EDIT: thanks for documenting the introductions for "traceability"

@practicalswift
[trivial] Fix three recently introduced typos
efc2e33 
```
$ git blame src/policy/fees.cpp | grep becuase
3810e97 (2017-03-07 11:33:44 -0500 789)          * checks for 2*target becuase we are taking the max over all time
$ git blame src/policy/fees.h | grep successfullly
2d2e170 (2017-04-12 12:29:03 -0400  54)  * representing that a tx was successfullly confirmed in less than or equal to
$ git blame src/wallet/feebumper.cpp | grep "hasen't"
a387837 (2017-05-11 09:34:39 +0200 258)     // make sure the transaction still has no descendants and hasen't been mined in the meantime
```
@practicalswift
Copy link
Contributor Author

practicalswift commented May 23, 2017

Fixed another typo:

$ git blame src/wallet/feebumper.cpp | grep "hasen't"
a3878374 (2017-05-11 09:34:39 +0200 258)     // make sure the transaction still has no descendants and hasen't been mined in the meantime

Friendly ping @jonasschnelli :-)

@practicalswift practicalswift changed the title [trivial] Fix two recently introduced typos [trivial] Fix three recently introduced typos May 23, 2017
@jtimon
Copy link
Contributor

jtimon commented May 23, 2017

re-utACK efc2e33

@paveljanik
Copy link
Contributor

paveljanik commented May 26, 2017

reACK efc2e33

@sipa sipa merged commit efc2e33 into bitcoin:master May 26, 2017
sipa added a commit that referenced this pull request May 26, 2017
@sipa
Merge #10419: [trivial] Fix three recently introduced typos
b40ceed 
efc2e33 [trivial] Fix three recently introduced typos (practicalswift)

Tree-SHA512: 99e97f3c1350299dfce9c0c35547d480f25c0b877da311d9120f113afd3089eda31b88b2378e2370f288b0c41bb69cee0fd3abca661cd93d5a56982f90709f91
@practicalswift practicalswift mentioned this pull request Aug 14, 2018
Merged
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request Jul 24, 2019
@sipa @PastaPastaPasta
Merge bitcoin#10419: [trivial] Fix three recently introduced typos
d76cd90 
efc2e33 [trivial] Fix three recently introduced typos (practicalswift)

Tree-SHA512: 99e97f3c1350299dfce9c0c35547d480f25c0b877da311d9120f113afd3089eda31b88b2378e2370f288b0c41bb69cee0fd3abca661cd93d5a56982f90709f91
@practicalswift practicalswift deleted the typos-201705 branch April 10, 2021 19:31
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Aug 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

Docs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@practicalswift @paveljanik @fanquake @morcos @jtimon @sipa