[scripts] Minor improvements to macdeployqtplus script.
#10273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if os.path.exists(fromContentsDir): | ||
| toContentsDir = os.path.join(path, framework.destinationVersionContentsDirectory) | ||
| shutil.copytree(fromContentsDir, toContentsDir, symlinks=True) | ||
| contentslinkfrom = os.path.join(path, framework.destinationContentsDirectory) |
Contributor
There was a problem hiding this comment.
What's the reason to remove this line? We don't use dynamic linked custom Frameworks in the Bitcoin-Qt.app bundle.
Contributor
Author
There was a problem hiding this comment.
In af0bd5e, the majority of this code was removed but I think this line was left in by mistake. As far as I can tell it doesn't do anything - it just defines a variable that is never used.
Contributor
|
Yes. Makes sense (though a very tiny optimisation/cleanup near PR "dust-limit"). |
Contributor
|
Builds the DMG correctly (https://bitcoin.jonasschnelli.ch/build/113). |
PastaPastaPasta
pushed a commit
to PastaPastaPasta/dash
that referenced
this pull request
May 20, 2019
jasonbcox
pushed a commit
to Bitcoin-ABC/bitcoin-abc
that referenced
this pull request
Oct 17, 2020
Summary: Backport of core [[bitcoin/bitcoin#10273 | PR10273]]. Test Plan: ninja osx-dmg Reviewers: #bitcoin_abc, deadalnix Reviewed By: #bitcoin_abc, deadalnix Differential Revision: https://reviews.bitcoinabc.org/D7967
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.