[doc] Contributor fixes & new "finding reviewers" section #10211
Conversation
|
Seems reasonable. Should definitely have such a section. |
|
ACK |
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
I think 'disregarded' is too strong here. It will be delayed for merge, but there's no rule preventing e.g. discussion or people from testing it.
There was a problem hiding this comment.
Makes sense. Changing to "will not be prioritized".
CONTRIBUTING.md
Outdated
CONTRIBUTING.md
Outdated
There was a problem hiding this comment.
Good suggestion.
It looks like github also provides reviewer suggestions based on who touched the code before (see e.g. #10202, or any pull that hasn't got any reviewers yet)
There was a problem hiding this comment.
That may be for members only. I don't see any suggestions on that PR but I've seen suggestions on PR's on repos to which I have merge access.
|
Looks good to me |
186540f to
3ddd227
Compare
|
Addressed issues pointed out by @laanwj. If anyone has any other improvements they'd like to see do let me know! |
|
ACK 3ddd227 Nice addition, thank you! |
I am summarising the suggestions given to me on IRC earlier regarding finding peer reviewers for pull requests.
I am also doing some general wording tweaks while at it.
I am somewhat concerned this is too wordy and maybe shouldn't be in
CONTRIBUTING.mdbut in a separate file (FINDINGPEERREVIEWERS.mddoesn't really float my boat). Feedback welcome. This was one of the biggest frustrations I had when I started out, and I think it's worth some space somewhere.