Skip to content

Conversation

@KibbledJiveElkZoo
Copy link
Contributor

Changed the "Send" button's default status from true to false to prevent
quirky Windows autofocus behavior.

Changed the "Send" button's default status from true to false to prevent
quirky Windows autofocus behavior.
@maflcko maflcko added the GUI label Apr 10, 2017
@laanwj
Copy link
Member

laanwj commented Apr 11, 2017

utACK 8c3e6c6

Would be useful to reference that this fixes #10174.

@KibbledJiveElkZoo
Copy link
Contributor Author

This change prevents the cursor from being repositioned in undesired places as mentioned in #10174.

@laanwj laanwj merged commit 8c3e6c6 into bitcoin:master Apr 12, 2017
laanwj added a commit that referenced this pull request Apr 12, 2017
8c3e6c6 Changed "Send" button default status from true to false (KibbledJiveElkZoo)

Tree-SHA512: e60d7481351e88925d99b33bdb616f3c234e93ef052571b9c4a1328186ec9abb8b61b0c4299afcb731edad2634aef6b1adaad121646b6c0c56dc933662904674
@KibbledJiveElkZoo
Copy link
Contributor Author

KibbledJiveElkZoo commented Jun 17, 2017

@laanwj Does my massive contribution warrant my inclusion in the 0.14.2 release "Credits"?

https://bitcoin.org/en/release/v0.14.2

If so I like to be referenced as "Kibbled Jive Elk Zoo". (If not then I claim I like to be referenced as "".)

@achow101
Copy link
Member

achow101 commented Jun 17, 2017

@KibbledJiveElkZoo "massive" (not really). Your change will be included and credited in Bitcoin Core 0.15.0. It is not a big enough bug fix to be included in 0.14.2 which has been already released.

@laanwj
Copy link
Member

laanwj commented Jun 17, 2017

Everyone that contributes to a release warrants being included in the credits in the "contributed to this release directly" list, no exceptions.

But as @achow101 says this wasn't part of 0.14.2, so it won't be in those. Usually for the name we automatically use the name you used for the commit author, so "KibbledJiveElkZoo".

I guess we could consider this for 0.14.3. In any case it will be in 0.15.0 (as its in master).

@KibbledJiveElkZoo
Copy link
Contributor Author

I thank you both for the trouble of expending time babysitting my nearly equally massive vain insecurity.

laanwj added a commit that referenced this pull request Aug 14, 2017
Update release notes from wiki, and fill in authors list from git.

Additional credits:

- Awemany (for #10854)
- Gregory Maxwell (release notes writing)
- John Newbery (release notes writing)
- Kibbled Jive Elk Zoo (for #10177 (comment))
- Luke Dashjr (release notes writing)
- Marco Falke (release notes writing)
- Pieter Wuille (release notes writing)
- Rusty Russell (release notes writing)
- tintinweb (for early-announcing miniupnp CVE-2017-8798, forgot this for 0.14.2)

Tree-SHA512: 8024eb761fcac4bb7f16ba3a9db376508f1f1bcf8a89cfb5e2928ad384675d3e912cada6ffef7d5aac181a965ebb8b823f6a63d9e976c1be753ec8eb9a8b9ef5
mempko pushed a commit to meritlabs/merit that referenced this pull request Sep 28, 2017
Update release notes from wiki, and fill in authors list from git.

Additional credits:

- Awemany (for #10854)
- Gregory Maxwell (release notes writing)
- John Newbery (release notes writing)
- Kibbled Jive Elk Zoo (for bitcoin/bitcoin#10177 (comment))
- Luke Dashjr (release notes writing)
- Marco Falke (release notes writing)
- Pieter Wuille (release notes writing)
- Rusty Russell (release notes writing)
- tintinweb (for early-announcing miniupnp CVE-2017-8798, forgot this for 0.14.2)

Tree-SHA512: 8024eb761fcac4bb7f16ba3a9db376508f1f1bcf8a89cfb5e2928ad384675d3e912cada6ffef7d5aac181a965ebb8b823f6a63d9e976c1be753ec8eb9a8b9ef5
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request May 20, 2019
…o false

8c3e6c6 Changed "Send" button default status from true to false (KibbledJiveElkZoo)

Tree-SHA512: e60d7481351e88925d99b33bdb616f3c234e93ef052571b9c4a1328186ec9abb8b61b0c4299afcb731edad2634aef6b1adaad121646b6c0c56dc933662904674
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants