-
Notifications
You must be signed in to change notification settings - Fork 38.7k
Changed "Send" button default status from true to false #10177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Changed the "Send" button's default status from true to false to prevent quirky Windows autofocus behavior.
|
This change prevents the cursor from being repositioned in undesired places as mentioned in #10174. |
8c3e6c6 Changed "Send" button default status from true to false (KibbledJiveElkZoo) Tree-SHA512: e60d7481351e88925d99b33bdb616f3c234e93ef052571b9c4a1328186ec9abb8b61b0c4299afcb731edad2634aef6b1adaad121646b6c0c56dc933662904674
|
@laanwj Does my massive contribution warrant my inclusion in the 0.14.2 release "Credits"? https://bitcoin.org/en/release/v0.14.2 If so I like to be referenced as "Kibbled Jive Elk Zoo". (If not then I claim I like to be referenced as "".) |
|
@KibbledJiveElkZoo "massive" (not really). Your change will be included and credited in Bitcoin Core 0.15.0. It is not a big enough bug fix to be included in 0.14.2 which has been already released. |
|
Everyone that contributes to a release warrants being included in the credits in the "contributed to this release directly" list, no exceptions. But as @achow101 says this wasn't part of 0.14.2, so it won't be in those. Usually for the name we automatically use the name you used for the commit author, so "KibbledJiveElkZoo". I guess we could consider this for 0.14.3. In any case it will be in 0.15.0 (as its in master). |
|
I thank you both for the trouble of expending time babysitting my nearly equally massive vain insecurity. |
Update release notes from wiki, and fill in authors list from git. Additional credits: - Awemany (for #10854) - Gregory Maxwell (release notes writing) - John Newbery (release notes writing) - Kibbled Jive Elk Zoo (for #10177 (comment)) - Luke Dashjr (release notes writing) - Marco Falke (release notes writing) - Pieter Wuille (release notes writing) - Rusty Russell (release notes writing) - tintinweb (for early-announcing miniupnp CVE-2017-8798, forgot this for 0.14.2) Tree-SHA512: 8024eb761fcac4bb7f16ba3a9db376508f1f1bcf8a89cfb5e2928ad384675d3e912cada6ffef7d5aac181a965ebb8b823f6a63d9e976c1be753ec8eb9a8b9ef5
Update release notes from wiki, and fill in authors list from git. Additional credits: - Awemany (for #10854) - Gregory Maxwell (release notes writing) - John Newbery (release notes writing) - Kibbled Jive Elk Zoo (for bitcoin/bitcoin#10177 (comment)) - Luke Dashjr (release notes writing) - Marco Falke (release notes writing) - Pieter Wuille (release notes writing) - Rusty Russell (release notes writing) - tintinweb (for early-announcing miniupnp CVE-2017-8798, forgot this for 0.14.2) Tree-SHA512: 8024eb761fcac4bb7f16ba3a9db376508f1f1bcf8a89cfb5e2928ad384675d3e912cada6ffef7d5aac181a965ebb8b823f6a63d9e976c1be753ec8eb9a8b9ef5
…o false 8c3e6c6 Changed "Send" button default status from true to false (KibbledJiveElkZoo) Tree-SHA512: e60d7481351e88925d99b33bdb616f3c234e93ef052571b9c4a1328186ec9abb8b61b0c4299afcb731edad2634aef6b1adaad121646b6c0c56dc933662904674
Changed the "Send" button's default status from true to false to prevent
quirky Windows autofocus behavior.