Skip to content

Speed Up CuckooCache tests #10128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
laanwj merged 1 commit into from
Apr 2, 2017
Merged

Speed Up CuckooCache tests #10128

laanwj merged 1 commit into from
Apr 2, 2017

Conversation

@JeremyRubin
Copy link
Contributor

@JeremyRubin JeremyRubin commented Mar 30, 2017

I decreased all the sizes, should be much faster. Shouldn't impact correctness of the cache or likelihood of catching bugs in the cache.

Can be reverted if we want to do extended tests later.

Addresses #10026

@fanquake fanquake added the Tests label Mar 30, 2017
@fanquake
Copy link
Member

fanquake commented Mar 31, 2017 •
edited
Loading

Tested with src/test/test_bitcoin --log_level=all --run_test=cuckoocache_tests

5 runs of master (edc62c9):

Leaving test suite "cuckoocache_tests"; testing time: 6987983us
Leaving test suite "cuckoocache_tests"; testing time: 6994218us
Leaving test suite "cuckoocache_tests"; testing time: 6903206us
Leaving test suite "cuckoocache_tests"; testing time: 7051359us
Leaving test suite "cuckoocache_tests"; testing time: 7055289us

avg = ~6998411us

vs 5 runs of this PR (3f098cc):

Leaving test suite "cuckoocache_tests"; testing time: 893674us
Leaving test suite "cuckoocache_tests"; testing time: 884415us
Leaving test suite "cuckoocache_tests"; testing time: 877087us
Leaving test suite "cuckoocache_tests"; testing time: 906258us
Leaving test suite "cuckoocache_tests"; testing time: 896657us

avg = ~891618us

= ~8times speedup

@paveljanik
Copy link
Contributor

paveljanik commented Mar 31, 2017

ACK 3f098cc

gmaxwell
gmaxwell approved these changes Apr 1, 2017
View reviewed changes
Copy link
Contributor

@gmaxwell gmaxwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@laanwj laanwj merged commit 3f098cc into bitcoin:master Apr 2, 2017
laanwj added a commit that referenced this pull request Apr 2, 2017
@laanwj
Merge #10128: Speed Up CuckooCache tests
427d2fd 
3f098cc Decrease testcase sizes in cuckoocache tests (Jeremy Rubin)

Tree-SHA512: 71a0e171be8d5473c791440aa4353d99b885b926b7284a3a1914c95e0c2c77925d5f3a6f329778cd81931a4e5832a082cb31d82ee8adb433d357d2e2b4f7a9e5
@laanwj laanwj mentioned this pull request Apr 2, 2017
Closed
PastaPastaPasta pushed a commit to PastaPastaPasta/dash that referenced this pull request May 20, 2019
@laanwj @PastaPastaPasta
Merge bitcoin#10128: Speed Up CuckooCache tests
818ec21 
3f098cc Decrease testcase sizes in cuckoocache tests (Jeremy Rubin)

Tree-SHA512: 71a0e171be8d5473c791440aa4353d99b885b926b7284a3a1914c95e0c2c77925d5f3a6f329778cd81931a4e5832a082cb31d82ee8adb433d357d2e2b4f7a9e5
@str4d str4d mentioned this pull request Apr 20, 2021
Merged
@bitcoin bitcoin locked as resolved and limited conversation to collaborators Dec 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@gmaxwell gmaxwell gmaxwell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Tests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@JeremyRubin @fanquake @paveljanik @gmaxwell @laanwj