[Qt] Ensure an item exists on the rpcconsole stack before adding #10060
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Confirmed that Core does segfault when using the above command in the rpcconsole, and that it no longer happens with the PR'd fix. |
paveljanik
reviewed
Mar 23, 2017
src/qt/rpcconsole.cpp
Outdated
Contributor
There was a problem hiding this comment.
space after if please and left brace on the same line (or maybe one line if without braces - see https://github.com/bitcoin/bitcoin/blob/master/doc/developer-notes.md).
Contributor
|
Concept ACK |
f9c9ef7 to
f3fa05a
Compare
Contributor
|
Thanks for pointing this out. diff --git a/src/qt/rpcconsole.cpp b/src/qt/rpcconsole.cpp
index 7a0d0b3..c2f6434 100644
--- a/src/qt/rpcconsole.cpp
+++ b/src/qt/rpcconsole.cpp
@@ -190,6 +190,7 @@ bool RPCConsole::RPCParseCommandLine(std::string &strResult, const std::string &
};
std::string strCommandTerminated = strCommand;
+ std::replace(strCommandTerminated.begin(),strCommandTerminated.end(),'\n',' ');
if (strCommandTerminated.back() != '\n')
strCommandTerminated += "\n";
for (chpos = 0; chpos < strCommandTerminated.size(); ++chpos) |
Member
Author
|
@jonasschnelli The segfault bug happens with more than just a newline in the command. It also happens if an end parenthesis |
sipa
reviewed
Mar 24, 2017
src/qt/rpcconsole.cpp
Outdated
Member
|
utACK, with nit. |
Ensures that there is an item on the rpcconsole stack before adding something to the current stack so that a segmentation fault does not occur.
f3fa05a to
4df76e2
Compare
Contributor
Contributor
|
Needs backport. |
jonasschnelli
added a commit
that referenced
this pull request
Mar 27, 2017
…re adding 4df76e2 Ensure an item exists on the rpcconsole stack before adding (Andrew Chow) Tree-SHA512: f3fd5e70da186949aff794f6e2ba122da2145331212dcc5e0595285bee9dc3aa6b400b15e8eeec4476099965b74f46c4ef80f8ed1e05d490580167b002b9a5e7
maflcko
pushed a commit
to maflcko/bitcoin-core
that referenced
this pull request
Mar 27, 2017
Ensures that there is an item on the rpcconsole stack before adding something to the current stack so that a segmentation fault does not occur. Github-Pull: bitcoin#10060 Rebased-From: 4df76e2
codablock
pushed a commit
to codablock/dash
that referenced
this pull request
Jan 26, 2018
…ck before adding 4df76e2 Ensure an item exists on the rpcconsole stack before adding (Andrew Chow) Tree-SHA512: f3fd5e70da186949aff794f6e2ba122da2145331212dcc5e0595285bee9dc3aa6b400b15e8eeec4476099965b74f46c4ef80f8ed1e05d490580167b002b9a5e7
andvgal
pushed a commit
to energicryptocurrency/gen2-energi
that referenced
this pull request
Jan 6, 2019
…ck before adding 4df76e2 Ensure an item exists on the rpcconsole stack before adding (Andrew Chow) Tree-SHA512: f3fd5e70da186949aff794f6e2ba122da2145331212dcc5e0595285bee9dc3aa6b400b15e8eeec4476099965b74f46c4ef80f8ed1e05d490580167b002b9a5e7
CryptoCentric
pushed a commit
to absolute-community/absolute
that referenced
this pull request
Feb 27, 2019
…ck before adding 4df76e2 Ensure an item exists on the rpcconsole stack before adding (Andrew Chow) Tree-SHA512: f3fd5e70da186949aff794f6e2ba122da2145331212dcc5e0595285bee9dc3aa6b400b15e8eeec4476099965b74f46c4ef80f8ed1e05d490580167b002b9a5e7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that there is an item on the rpcconsole stack before adding something to the current stack so that a segmentation fault does not occur.
Currently Bitcoin Core will just crash if there happens to be a newline somewhere in the command followed by some non-whitespace characters which are followed by a space. This causes a segfault by attempting to get the current stack from the empty stack vector. This fix ensures that that current stack always exists so that the segfault does not happen.
The crashing behavior can be tested by using this command in the rpcconsole:
(copy and paste it as one line)