BIP340 updates: clarifications, variable-length messages, expand domain separation #1446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
jonasnick
reviewed
Apr 21, 2023
Contributor
|
Is there anything to do on our side that prevents this from being merged? |
Contributor
|
Sorry for the delay. |
theStack
added a commit
to theStack/bitcoin
that referenced
this pull request
May 29, 2025
…messages) See bitcoin/bips#1446, commit 200f9b2
achow101
added a commit
to bitcoin/bitcoin
that referenced
this pull request
Jun 20, 2025
…riable-length messages) b184f5c test: update BIP340 test vectors and implementation (variable-length messages) (Sebastian Falbesoner) Pull request description: This PR updates the Schnorr signatures implementation in the functional test framework to the latest BIP changes (see bitcoin/bips#1446 200f9b2) and syncs the [test vectors](https://github.com/bitcoin/bips/blob/master/bip-0340/test-vectors.csv) accordingly. Practically, we probably don't need non-32-bytes message signing/verifying any time soon, but it seems good practice anyways to update. ACKs for top commit: stratospher: ACK b184f5c. achow101: ACK b184f5c real-or-random: utACK b184f5c jonasnick: utACK b184f5c Tree-SHA512: b566823aa0f1cd7151215178c57551d772b338d022ccb2807a0df2670df6d59c4b63a6fc936708ccf2922c7e59f474f544adaafc4aea731bfd896250c0d45fa6
HowHsu
pushed a commit
to HowHsu/bitcoin
that referenced
this pull request
Jun 23, 2025
…messages) See bitcoin/bips#1446, commit 200f9b2
janus
pushed a commit
to BitgesellOfficial/bitgesell
that referenced
this pull request
Sep 14, 2025
…messages) See bitcoin/bips#1446, commit 200f9b26fe0a2f235a2af8b30c4be9f12f6bc9cb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For clarification, this does not make any semantics changes apart from permitting messages to have another length than 32. BIP341 and BIP342 obviously keep making use of just the 32-byte ones, and are thus unaffected.