Formatting fix and https fix for sra toolkit download#5
Merged
bmpvieira merged 2 commits intobionode:masterfrom Apr 6, 2017
amanjeev:fix-latest-node
Merged
Formatting fix and https fix for sra toolkit download#5bmpvieira merged 2 commits intobionode:masterfrom amanjeev:fix-latest-node
bmpvieira merged 2 commits intobionode:masterfrom
amanjeev:fix-latest-node
Conversation
Member
|
Hey @amanjeev ! Thanks for the PR!! Would you just mind to follow the standardjs.com style? Cheers, |
Contributor
Author
|
Sure. Thanks for taking a look. Let me fix that and update the PR. Give me some time though.
|
Contributor
Author
|
Sorry it took longer than usual for merely formatting the code. Should be good now. I just used |
Member
|
No problem @amanjeev! One last thing, could you undo the changes to the comments? Those comments are formatted that way and used to generate the documentation with |
Contributor
Author
|
Sorry about this fiasco! I've reset the entire branch and just made the relevant changes. Now only two commits, what it should have been in the beginning anyway. :) |
Member
|
ahah don't worry, next time will be better! :) |
bmpvieira
approved these changes
Apr 6, 2017
Member
bmpvieira
left a comment
There was a problem hiding this comment.
Looks good! Thank you for spending your time on this. :)
Contributor
Author
|
Thank you for allowing me to participate!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @bmpvieira ! I made some minor changes to the repo. It fails to be installed because the url for SRA toolkit download was http. so I updates the Makefile.
I also formatted the code a bit.