Updating the CheckType function#1
Merged
bmpvieira merged 3 commits intobionode:masterfrom Nov 9, 2014
Merged
Conversation
|
Changes Unknown when pulling 1a5a317 on IsmailM:master into * on bionode:master*. |
bmpvieira
added a commit
that referenced
this pull request
Nov 9, 2014
Updating the CheckType function
bmpvieira
added a commit
that referenced
this pull request
Apr 20, 2015
Updating the CheckType function
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let me know what you think...
Here is a comparison between the original and the updated version... http://jsbin.com/fofadedopodu/1/edit?js,output
Note: Since ACGT are both bases and amino acid, it is sometime impossible to work out which type the sequence is... So this script checks if the sequence is DNA (or RNA) before, checking if it could be a protein (since for it to be a DNA or RNA sequence, there must be a higher percentage of ACGT). You can see an example of this problem in the above link...
BTW. I'm not too sure about line 10 on the test unit - is the
undefinedsupposed to be in the apostrophes?Also I haven't checked if the unit tests work...