switch from dld to nugget, upgrade some dependencies#5
Merged
bmpvieira merged 1 commit intobionode:masterfrom Oct 22, 2014
Merged
switch from dld to nugget, upgrade some dependencies#5bmpvieira merged 1 commit intobionode:masterfrom
bmpvieira merged 1 commit intobionode:masterfrom
Conversation
|
Changes Unknown when pulling 2b07987 on maxogden:nugget into * on bionode:master*. |
bmpvieira
added a commit
that referenced
this pull request
Oct 22, 2014
switch from dld to nugget, upgrade some dependencies
Member
|
Awesome PR, thanks! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I only realized after I implemented this that I think you already handled the case where bionode-ncbi would skip downloading if the file already exists locally, but I finished this PR nonetheless since
nuggethandles that automatically and at least this removes more code than it adds :)