Skip to content

Prevent progress bar from starting if file already exists#30

Merged
tiagofilipe12 merged 1 commit intomasterfrom
progress-bar
Apr 20, 2017
Merged

Prevent progress bar from starting if file already exists#30
tiagofilipe12 merged 1 commit intomasterfrom
progress-bar

Conversation

@tiagofilipe12
Copy link
Member

@tiagofilipe12 tiagofilipe12 commented Apr 16, 2017 •
edited
Loading

This change only affects --pretty option, and prevents progress bar from starting when file already exists, which rendered an odd 0% progress when output already exists in file system. Makes more sense if we raise an error message and do not start progress bar at all.

@bmpvieira bmpvieira self-requested a review April 17, 2017 09:33
@tiagofilipe12 tiagofilipe12 force-pushed the progress-bar branch 2 times, most recently from 3cfa511 to 3cd411b Compare April 19, 2017 18:24
bmpvieira
bmpvieira approved these changes Apr 20, 2017
View reviewed changes
Copy link
Member

@bmpvieira bmpvieira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thanks! Long term, we might want to change how we deal with errors and info. #29 (comment)

@tiagofilipe12 tiagofilipe12 merged commit 53ac37e into master Apr 20, 2017
bmpvieira added a commit that referenced this pull request Apr 22, 2017
@bmpvieira
Better CLI, fix #30, #29, #20 and #11
3d8f383 
Switch from minimist to yargs for CLI parsing
Add list of possible databases with yargs
Indent JSON output when --pretty
Allow piping JSON, even for fetch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bmpvieira bmpvieira bmpvieira approved these changes

Assignees

@tiagofilipe12 tiagofilipe12

Labels

ux

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tiagofilipe12 @bmpvieira