Skip to content

owscatterplotgraph: Make + and x symbols thicker#5007

Merged
ajdapretnar merged 1 commit intobiolab:masterfrom
irgolic:more-visible-subset-graph-symbols
Oct 2, 2020
Merged

owscatterplotgraph: Make + and x symbols thicker#5007
ajdapretnar merged 1 commit intobiolab:masterfrom
irgolic:more-visible-subset-graph-symbols

Conversation

@irgolic
Copy link
Copy Markdown
Member

@irgolic irgolic commented Sep 28, 2020

Issue

Fixes #4967

Screenshot 2020-09-28 at 21 19 41

Includes
  • Code changes
  • Tests
  • Documentation

@codecov
Copy link
Copy Markdown

codecov bot commented Sep 28, 2020

Codecov Report

Merging #5007 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #5007      +/-   ##
==========================================
- Coverage   84.65%   84.65%   -0.01%     
==========================================
  Files         284      284              
  Lines       58935    58952      +17     
==========================================
+ Hits        49894    49908      +14     
- Misses       9041     9044       +3     

irgolic added a commit to irgolic/pyqtgraph that referenced this pull request Oct 1, 2020
This is something we're overriding in Orange3 (biolab/orange3#5007), as we change the symbols' alpha_value to show selected symbols. The default + and x symbols are too thin to show a noticeable change in alpha_value.

But I thought you might agree that the symbols look nicer this way.
@ajdapretnar
Copy link
Copy Markdown
Contributor

I like this. It looks much better.

@ajdapretnar ajdapretnar merged commit d67de0f into biolab:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some shapes don't convey selection well

2 participants