This repository was archived by the owner on Aug 15, 2025. It is now read-only.
Made the compatibility check also include bincode 2 serde, and added comments#501
Merged
VictorKoenders merged 2 commits intotrunkfrom Feb 6, 2022
Merged
Made the compatibility check also include bincode 2 serde, and added comments#501VictorKoenders merged 2 commits intotrunkfrom
VictorKoenders merged 2 commits intotrunkfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## trunk #501 +/- ##
==========================================
+ Coverage 68.35% 69.07% +0.72%
==========================================
Files 43 43
Lines 3049 3056 +7
==========================================
+ Hits 2084 2111 +27
+ Misses 965 945 -20
Continue to review full report at Codecov.
|
ghost
approved these changes
Feb 6, 2022
ppamorim
pushed a commit
to ppamorim/bincode
that referenced
this pull request
Feb 6, 2022
…comments (bincode-org#501) * Made the compatibility check also include bincode 2 serde, and added comments * Added a CI step to run the compatibility tests
ppamorim
pushed a commit
to ppamorim/bincode
that referenced
this pull request
Feb 6, 2022
…comments (bincode-org#501) * Made the compatibility check also include bincode 2 serde, and added comments * Added a CI step to run the compatibility tests
ppamorim
pushed a commit
to ppamorim/bincode
that referenced
this pull request
Feb 6, 2022
…comments (bincode-org#501) * Made the compatibility check also include bincode 2 serde, and added comments * Added a CI step to run the compatibility tests
ppamorim
pushed a commit
to ppamorim/bincode
that referenced
this pull request
Feb 6, 2022
…comments (bincode-org#501) * Made the compatibility check also include bincode 2 serde, and added comments * Added a CI step to run the compatibility tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the code was redundant because we confirmed that the
bincode_1_outputwas identical to thebincode_2_output. Therefor deserializing the same slice twice won't give different results.Added a validation that
bincode_2::serdealso (de)serializes the same.