Handle LookupError when detecting encoding#17
Merged
audreyfeldroy merged 1 commit intobinaryornot:masterfrom Aug 19, 2015
DRMacIver:fix-lookup-error
Merged
Handle LookupError when detecting encoding#17audreyfeldroy merged 1 commit intobinaryornot:masterfrom DRMacIver:fix-lookup-error
audreyfeldroy merged 1 commit intobinaryornot:masterfrom
DRMacIver:fix-lookup-error
Conversation
For reasons that are a slight mystery to me, chardet can return encodings that Python doesn't actually support. On the assumption that if we can't decode it we're probably not interested in considering it as text (especially given that chardet will sometimes detect an encoding that you can't actually decode as when its confidence is < 1), this handles this commit by considering it to not be decodable.
audreyfeldroy
added a commit
that referenced
this pull request
Aug 19, 2015
Handle LookupError when detecting encoding
Collaborator
|
@DRMacIver thanks for catching this, much appreciated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For reasons that are a slight mystery to me, chardet can return
encodings that Python doesn't actually support.
On the assumption that if we can't decode it we're probably not
interested in considering it as text (especially given that chardet
will sometimes detect an encoding that you can't actually decode as
when its confidence is < 1), this handles this commit by
considering it to not be decodable.