Add very simple Hypothesis based tests#13
Merged
audreyfeldroy merged 1 commit intobinaryornot:masterfrom Aug 19, 2015
DRMacIver:add-hypothesis
Merged
Add very simple Hypothesis based tests#13audreyfeldroy merged 1 commit intobinaryornot:masterfrom DRMacIver:add-hypothesis
audreyfeldroy merged 1 commit intobinaryornot:masterfrom
DRMacIver:add-hypothesis
Conversation
Contributor
Author
|
Hm. That failure is weird. Python is distributed as source, and it's certainly supposed to work (and is tested!) on windows on 2.7, so I can't think why appveyor wouldn't be finding it. |
Contributor
Author
|
I've no good ideas there. I'd suggest restarting that one appveyor job to see if it was a transient error in downloading something (though it doesn't look like it) and otherwise I'll take a look at this problem tomorrow or another time and you shouldn't worry about it. Sorry about that! |
Collaborator
|
@DRMacIver It appears to have been a small problem with the |
This is essentially a "getting started" test. All it does is assert that the is_binary function should never crash regardless of what's in the file. There should be more interesting things to test here, but most of the additional things I've tried fail and it's unclear that these are really bugs so much as edge cases in the heuristic. Note: This is the test that caught ssue #12.
Contributor
Author
|
Sure, done. Thanks for fixing that. |
audreyfeldroy
added a commit
that referenced
this pull request
Aug 19, 2015
Add very simple Hypothesis based tests
Collaborator
|
This is so cool, thanks so much @DRMacIver! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially a "getting started" test. All it does is assert
that the is_binary function should never crash regardless of what's
in the file.
There should be more interesting things to test here, but most of
the additional things I've tried fail and it's unclear that these
are really bugs so much as edge cases in the heuristic.
Note: This is the test that caught issue #12.