Skip to content

Consistency - shares not users#112

Closed
licaon-kter wants to merge 1 commit intobilde2910:masterfrom
licaon-kter:patch-4
Closed

Consistency - shares not users#112
licaon-kter wants to merge 1 commit intobilde2910:masterfrom
licaon-kter:patch-4

Conversation

@licaon-kter
Copy link
Copy Markdown
Contributor

No description provided.

@bilde2910
Copy link
Copy Markdown
Owner

A share can have one or more members. Shares with more than one member are called group shares, see e.g. the selector for "sharing mode" on the app. They're still just one share, however. So when you view a group share in the browser, you're viewing one share with multiple members/participants.

@licaon-kter
Copy link
Copy Markdown
Contributor Author

licaon-kter commented Dec 17, 2019

I can add a group share to a group share?

I thought an entry is one individual share

/LE: Just tested, errors out with "adoption not permitted"

@bilde2910
Copy link
Copy Markdown
Owner

You can't add two group shares together, but you can add a single user share to a group share. What actually happens when you do that, is that the owner of the single user share starts broadcasting to two shares instead of just one - his own personal share, and the group share in question. The group share will also show up as a separate share in the app for that person, as "Group share (member)". Hence, they will then have an active participation in multiple shares.

When you use the "Create new tracking link" button, that also creates a new share, but is still the same user.

@licaon-kter
Copy link
Copy Markdown
Contributor Author

licaon-kter commented Dec 17, 2019

I think we are lost in translation here, I know what's going on inside the app.

Not sure why those need to be "users" in this one string only when they're called "shares" everywhere else.

@bilde2910
Copy link
Copy Markdown
Owner

I think that may be a case to rephrase the others away from "share" in that case. I may not have chosen the best phrasing for some of the strings. I'll push some commits here

@bilde2910
Copy link
Copy Markdown
Owner

bilde2910 commented Dec 17, 2019

Pushed a commit above. If I missed any, feel free to let me know

E: Looks like I accidentally pushed to master instead of the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants