Skip to content

[ENH] Add "ScanRAS" as an accepted coordinate frame for ieeg#866

Merged
sappelhoff merged 3 commits intobids-standard:masterfrom
alexrockhill:scanras
Sep 9, 2021
Merged

[ENH] Add "ScanRAS" as an accepted coordinate frame for ieeg#866
sappelhoff merged 3 commits intobids-standard:masterfrom
alexrockhill:scanras

Conversation

@alexrockhill
Copy link
Copy Markdown
Contributor

Fixes #747.

@tsalo
Copy link
Copy Markdown
Member

tsalo commented Sep 1, 2021

ScanRAS will also need to be added to the list of acceptable iEEG coordinate systems in the schema:

---
type: string
enum:
- Pixels
- ACPC
- Other

Copy link
Copy Markdown
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after Taylors comment has been addressed

Also, I feel like this thread should be merged PRIOR as well: fieldtrip/website#444

@alexrockhill
Copy link
Copy Markdown
Contributor Author

Ok sorry this took so long, I added ScanRAS and Robert merged the other PR so this may be next

@sappelhoff sappelhoff merged commit 7d21713 into bids-standard:master Sep 9, 2021
@sappelhoff
Copy link
Copy Markdown
Member

Thanks @alexrockhill

@sappelhoff sappelhoff changed the title [ENH, MRG] Add "ScanRAS" as an accepted coordinate frame for ieeg [ENH] Add "ScanRAS" as an accepted coordinate frame for ieeg Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Storing iEEG electrodes with locations from FreeSurfer image

3 participants