[FIX] What is a composite instance? Change to measurement for non MRI modalities?#813
Merged
sappelhoff merged 10 commits intobids-standard:masterfrom Jun 9, 2021
Merged
Conversation
sappelhoff
reviewed
Jun 1, 2021
src/04-modality-specific-files/06-physiological-and-other-continuous-recordings.md
Outdated
Show resolved
Hide resolved
Member
|
PS: linkchecker fails due to biosemi.com failing to renew their certificates (?) ... https fails, but http works. You could just change the link from https to http for now. I am not sure when they'll manage to get their https back up. |
Member
Author
|
FYI @mshader (#802 (comment)) |
effigies
reviewed
Jun 8, 2021
Member
Author
|
@sappelhoff I think I addressed all issues. How/who do I ping for review? There seems to be ways to ping a team, is that what I should do? And which team? |
Member
|
@rob-luke these are the teams you can ping: https://github.com/orgs/bids-standard/teams/everyone --> all nested under "everyone", so if you ping [at]bids-standard/everyone, EVERYBODY will get a notification ... if you go down the nesting, the amount of pings reduces accordingly. Usually it's fine to ping one of the maintainers that you last were in touch with about an issue/pr. |
sappelhoff
approved these changes
Jun 9, 2021
Member
Author
|
Thanks @sappelhoff for explaining. Looks like this is good to go then :) |
Member
|
Yes, I think so too, will merge! Thanks a lot :-) Just a note for you: Usually we wait about 5 days after the most recent commit before merging a PR, to give the community enough time to see it, see: https://github.com/bids-standard/bids-specification/blob/master/DECISION-MAKING.md#rules But in this case it's a relatively uncontroversial fix that has been approved and open for many days now without many changes. |
Member
Author
|
Will do @sappelhoff, and Ill be sure to read through that document too. |
bids-maintenance
added a commit
that referenced
this pull request
Jun 9, 2021
27 tasks
tsalo
added a commit
that referenced
this pull request
Jul 13, 2021
* [SCHEMA] Add metadata term files (#762) * Draft a handful of metadata term files. * Add example with specific possible values. * Match the validator schemas better. * Fix formatting. * Fix formatting again! * Draft semi-functional rendering functions. * Use unit abbreviations. * Add more fields. * Get macro working. * Add terms from first table. * Add AnatomicalLandmarkCoordinateSystem. * fMRI task information table. * More terms. * More terms. * More terms. * EchoTime and FlipAngle * Add tables. * More tables. * More terms. * More terms. * More terms. * Fix spacing. * Clean things up. * More terms. * More terms! * More terms. * Some iEEG terms. * More iEEG terms. * Add ASL labeling terms. * Next batch. * More terms. * More terms. * More terms. * Fix mistakes. * Last terms. * Reference yamls. * Fix mistakes. * Change format of coordinate system files. * Use degree in associated files. * Some of the missing terms. * A few more terms. * Fix typos. * More terms. * More terms. * More terms. * More terms. * More terms. * More terms. * Last terms. * Fix link. * Fix internal links. * Fix links for real. * Derivative terms. * Fix up code link. * Use backslashes for continued strings. * Replace $ref with file contents. Also support plural datatype strings and all manner of newlines in descriptions. * Fix genetics. * Describe the structure of metadata YAML files. * Make metadatatype function recursive. * Improve search function. * Start adding PET fields. * Add some fields. * More terms. * More terms. * More terms. * Fix mistakes. * More terms. * Replace InstitutionDepartmentName with existing InstitutionalDepartmentName. * More terms. * More terms. * More terms. * More terms. * More terms. * More terms. * More terms. * Last terms. * Add unit format for strings. Unused for now but could be useful later. * Add dataset_relative and participant_relative string formats. * Update READMEs. * Fix formats in README. * Support table-specific metadata description extensions. * Employ description extensions with IntendedFor. * Remove explicit defaults from YAML files. * Replace Minimum with minimum. * Replace inclusiveMaximum with maximum. * Replace implicit links with explicit ones. * Rename key_name to name. * Rename "Unit" to "Units" * Improve make_metadata_table docstring. * Start addressing inconsistencies between rendered and hardcoded tables. * Fix typos in PET metadata From #786. * Add metadata fields from qMRI appendix. * Fix. * Address duplicate datatypes. Should address the "string or string or string or string" issue. * Wrap example strings in code. * Use enum for n/a instead of pattern. It's easier to identify as a special case. * Replace "string" with "n/a" when appropriate. * Address some inconsistencies. * Take a crack as SpatialReference. The type is complicated, but I _think_ I've got it figured out. * Apply suggestions from code review Thanks @effigies! Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu> * Update tools/schemacode/schema.py * search_structure --> dereference_yaml * Use faster loading approach. * Fix deprecation link. * Apply suggestions from code review Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu> * Update 01-magnetic-resonance-imaging-data.md * Add B0FieldIdentifier and B0FieldSource. * Revert type changes and add TODOs to check them. * Update tools/schemacode/schema.py * Replace remaining relative links. * Apply suggestions from code review Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu> * Add new coordinate systems from #775. * Grab hack from #781 (which wasn't merged). * Create HED.yaml * boldify table headers * add device info metadata * fix table fences * fix cell padding * fix cell padding this is getting old VERY quickly * Fix up DICOM tags in metadata. * Leverage "name" field for section-specific metadata definitions. * composite instances --> measurements Changes from #813. * Fix name of HED field. * Fix string formatting in coordinate system fields. * Move "preferably same as" to section-specific text. For #774 (comment) * Standardize DICOM Tag format. Still need to move the references out of the generic definitions. * Move mentions of DICOM Tags out of definitions. Only for fields that *also* appear in modalities that *don't* use DICOM. * Apply suggestions from code review Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Generalize SoftwareFilters example. * Distinguish AnatomicalLandmarkCoordinates definitions. * Rename fmapEchoTime to match new format. * Apply suggestions from code review Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Apply suggestions from code review Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Address review. * Fix example manufacturer names. * TEMPORARY: fix osipi URL (revert when osipi.org is back) * Fix regex for identifying macros. * Partially address review. * Do not assume minItems is 1 for array terms. * composite instances --> measurements (again) * Update src/schema/metadata/MagneticFieldStrength.yaml Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Update description to PharmaceuticalDoseTime #774 (comment) * Update 09-positron-emission-tomography.md * fix table pipe alignment * add pharmaceuticaldosetime fix to schema includes a bugfix to convert "should" (not casing, this was not intended as a SHOULD) to a MUST. * fix str examples * Apply suggestions from code review Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Update src/schema/metadata/RepetitionTimeExcitation.yaml Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> * Add DoseCalibrationFactor. * Update ScanDate definition and deprecate it. * Remove hardcoded tables. * Remove unused links. * Update tools/schemacode/schema.py Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu> Co-authored-by: Chris Markiewicz <markiewicz@stanford.edu> Co-authored-by: Remi Gau <remi_gau@hotmail.com> Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org> Co-authored-by: mnoergaard <martin.noergaard@nru.dk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is a composite instance? I had never heard this term before and don't believe it is used in EEG or fNIRS. I googled it and it appears to be a DICOM specific term and thus fMRI specific? But I found the terminology in EEG MEG iEEG and Physiological pages.
I suggest either changing it to measurement (as in this PR), or adding a definition somewhere in the specification.
This is an issue as a PR. Hope that's ok.