[ENH] Add device and acquisition metadata for physio files#806
Merged
sappelhoff merged 3 commits intobids-standard:masterfrom May 27, 2021
Merged
[ENH] Add device and acquisition metadata for physio files#806sappelhoff merged 3 commits intobids-standard:masterfrom
sappelhoff merged 3 commits intobids-standard:masterfrom
Conversation
sappelhoff
approved these changes
May 22, 2021
tsalo
approved these changes
May 24, 2021
Member
tsalo
left a comment
There was a problem hiding this comment.
It looks like you introduced some trailing whitespace that will need to be trimmed before merging, but the content looks good to me.
sappelhoff
reviewed
May 25, 2021
Member
sappelhoff
left a comment
There was a problem hiding this comment.
as discussed in maintainers meeting, we need to update: https://github.com/bids-standard/bids-validator/blob/master/bids-validator/validators/json/schemas/physio.json
Member
|
Will need to apply changes to #774 too. |
effigies
approved these changes
May 25, 2021
Member
|
note: I committed a fix for a broken link from this PR in 63db4a8 and pushed directly to master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #803
Add the following keys for physio files (NOT for stim files)