[INFRA] In PDF, color every other row in table in light gray fill#794
[INFRA] In PDF, color every other row in table in light gray fill#794sappelhoff merged 6 commits intobids-standard:masterfrom
Conversation
|
(Just swinging by here because I bet this was a weirdly hard PR but I think it will be super useful! Thank you 🙏 ) |
|
Is it possible to improve the alignment of the gray fill with the text/borders? Also, I think it would look a little nicer if the header row remained white. In fact, I feel like I would flip it exactly, since there's a line to distinguish the header from the first row, so both could be white. |
effigies
left a comment
There was a problem hiding this comment.
Definitely an improvement in any case. Thanks!
yes, something is fishy but I couldn't figure out the problem. See these two tables on page 99: They have different coloring although according to the setting, they shouldn't have. Screenshot:
|
Am I wrong or the first rwo being gray is not consistent from one table to the next? But as @effigies said, an improvement already so heppy to merge as is and improve later. |
no, you are correct 😄 this is something I couldn't figure out, and that I gave up after about one hour of screaming: #794 (comment) |
ONE HOUIR!? I admire your tenacity. |
closes #659
This took me way longer than it should have ... there are many challenges with our pdf generation code, but I think I fixed more than I destroyed. Some of the options we were passing previously were never actually passed, and I still need to figure out why.
Anyhow, this is a start:
From my side, this is ready to be merged - but a lot remains to be done in the future.