[ENH] allow _dir for other EPI (func, dwi) sequences#78
[ENH] allow _dir for other EPI (func, dwi) sequences#78chrisgorgo merged 1 commit intobids-standard:masterfrom
Conversation
|
Pinging @bids-standard/bep_leads for comments. |
|
it almost seems like we just want a disambiguation mnemonic. but i feel that naming things in filenames should be as restrictive as possible. alternatively, we can adopt more generally what we discussed in derivatives meeting that any key and value can be added to the filename in pairs, but in general only a disambiguation mnemonic suffices. |
|
While doing it I thought that may be detailed descriptions for all those key/pairs shared by different modalities could be brought into a single location, where it would be easy to reference them. Eg as subsections of src/99-appendices/04-entity-table.md ? |
|
hm, ... wise words @satra ;-) |
|
@yarikoptic what's the status after @satra comments? Would you be ok closing this PR? |
|
I thought / looked at it a bit more and was provided some counter examples, e.g. HCP dataset where the same task would have LR and RL "runs". Sure thing it could be encoded within Please let me know what you think @chrisfilo and @satra |
|
I still don't think it's necessary and |
|
@yarikoptic I have seen that too and while not ideal, it is what happens in the wild. Though the sidecar JSON should have things like PhaseEncodingAxis and PhaseEncodingDirection, the filenames up top would appear as two of the same runs though they could be more easily differentiated by just a more appropriate |
|
Thank you @ericearl . Taking it with @kaczmarj 's comment at #47 (comment) I think there is enough community support/interest to see it implemented. I will refurbish this PR for merge |
See bids-standard#47 for initial brief discussion. This commit also demonstrates ability to reference other sections within the document (when referencing fmap Case 4 where _dir described in greater detail ATM
|
ready... |
|
Thanks! |
…tion synch bids-bep016 with current state of bids-specification [MISC]
Closes #47
This commit also demonstrates ability to reference other sections within the
document (when referencing fmap Case 4 where _dir described in greater detail
ATM