[FIX] Fixing template string on electrodes for eeg and ieeg.#650
Merged
sappelhoff merged 2 commits intobids-standard:masterfrom Oct 29, 2020
Merged
[FIX] Fixing template string on electrodes for eeg and ieeg.#650sappelhoff merged 2 commits intobids-standard:masterfrom
sappelhoff merged 2 commits intobids-standard:masterfrom
Conversation
sappelhoff
reviewed
Oct 22, 2020
Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
sappelhoff
approved these changes
Oct 25, 2020
Member
|
This is in accordance with the entity table: https://bids-specification.readthedocs.io/en/latest/99-appendices/04-entity-table.html#encephalography-eeg-ieeg-and-meg ... so this is truly a fix. unfortunately, as discussed in this issue comment, the validator is not precise enough to validate this. So the validator will still accept files like: Still +1 to merge, then adjust mne-bids (mne-tools/mne-bids#604), and then eventually improve the validator (better sooner than later) |
Member
|
Thanks @adam2392 |
bids-maintenance
added a commit
that referenced
this pull request
Oct 29, 2020
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes: #649
Fixes the template strings in the modality-specific spec to match that of https://bids-specification.readthedocs.io/en/stable/99-appendices/04-entity-table.html#encephalography-eeg-ieeg-and-meg