[ENH] Define "modality" and clarify "data type"#592
Merged
tsalo merged 2 commits intobids-standard:masterfrom Sep 16, 2020
Merged
[ENH] Define "modality" and clarify "data type"#592tsalo merged 2 commits intobids-standard:masterfrom
tsalo merged 2 commits intobids-standard:masterfrom
Conversation
hoechenberger
approved these changes
Sep 1, 2020
Member
|
WDYT of also slightly updating the definition of "data types" to clarify that they're reflected in folder names? |
339b525 to
f567a09
Compare
Collaborator
Author
|
That one was actually a bit harder to word, IMO. Let me know what you think. |
tsalo
approved these changes
Sep 10, 2020
Member
tsalo
left a comment
There was a problem hiding this comment.
I really like the updated "Data type" definition. I think this will really help with the confusion about terminology.
sappelhoff
approved these changes
Sep 11, 2020
agramfort
approved these changes
Sep 11, 2020
Member
|
Unless anyone raises any concerns about it, this PR should be good to merge tomorrow (5 days after second approval). |
Member
I agree that it's good to be merged, it's a nice clarification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #584.
Closes #586.
Reworded slightly from initial suggestion.