[INFRA] linkchecker - ignore github pull and tree URLs#477
Merged
yarikoptic merged 3 commits intobids-standard:masterfrom May 19, 2020
Merged
[INFRA] linkchecker - ignore github pull and tree URLs#477yarikoptic merged 3 commits intobids-standard:masterfrom
yarikoptic merged 3 commits intobids-standard:masterfrom
Conversation
It causes github to spit out "429 too many requests" HTTP error (see bids-standard#474). With this change we should skip ATM about 200 github URLs and be left with only about 30. Hopefully that would suffice
effigies
reviewed
May 18, 2020
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Collaborator
Author
|
Thank you @effigies for commenting with the suggestion - could accept or even while on the phone! |
effigies
reviewed
May 18, 2020
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
sappelhoff
approved these changes
May 19, 2020
Collaborator
Author
|
woohoo -- all green now. I guess we just need one more approval now @effigies and could have it merged |
franklin-feingold
approved these changes
May 19, 2020
Collaborator
franklin-feingold
left a comment
There was a problem hiding this comment.
lgtm thank you @yarikoptic
bids-maintenance
added a commit
that referenced
this pull request
May 19, 2020
Collaborator
|
Thanks @yarikoptic! |
yarikoptic
added a commit
to yarikoptic/bids-specification
that referenced
this pull request
May 22, 2020
* origin/master: [DOC] Auto-generate changelog entry for PR bids-standard#477 Also ignore users urls on github Quote regexp in command line [INFRA] linkchecker - ignore github pull and tree URLs
satra
added a commit
to satra/bids-specification
that referenced
this pull request
May 23, 2020
* upstream/master: (113 commits) [DOC] Auto-generate changelog entry for PR bids-standard#152 [DOC] Auto-generate changelog entry for PR bids-standard#467 Specify that suffix must be alphanumeric ENH: make NOT RECOMMENDED stronger (SHOULD NOT) for zero padding for uniqueness ENH: Include leading . within definition of the file extension ENH: provide an example for a suffix based on an _eeg.vhdr filename [DOC] Auto-generate changelog entry for PR bids-standard#477 [DOC] Auto-generate changelog entry for PR bids-standard#460 Also ignore users urls on github Quote regexp in command line [INFRA] linkchecker - ignore github pull and tree URLs Apply suggestions from code review replace purview with scope label -> index Apply suggestions from code review drop _part-, introduce _split- Apply SA feedback and amended to purview [DOC] Auto-generate changelog entry for PR bids-standard#459 Add Domain Expert to Maintainers Group [DOC] Auto-generate changelog entry for PR bids-standard#465 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It causes github to spit out "429 too many requests" HTTP error (Closes #474).
With this change we should skip ATM about 200 github URLs and be left
with only about 30. Hopefully that would suffice