[ENH] Add OPTIONAL EthicsApprovals field to dataset description#412
Merged
effigies merged 3 commits intobids-standard:masterfrom Feb 21, 2020
Merged
[ENH] Add OPTIONAL EthicsApprovals field to dataset description#412effigies merged 3 commits intobids-standard:masterfrom
effigies merged 3 commits intobids-standard:masterfrom
Conversation
satra
previously approved these changes
Feb 11, 2020
VisLab
reviewed
Feb 11, 2020
Member
VisLab
left a comment
There was a problem hiding this comment.
Instead of:
OPTIONAL. List of ethics committees that have approved the research protocols and/or protocol identifiers.
I would reword as: List of ethics committee approvals of the research protocols and/or protocol identifiers. (A string or an array of strings.)
Member
|
It should be OPTIONAL of course. |
Collaborator
Author
|
Rewording sounds good. The "(A string or an array of strings.)" doesn't appear in any other fields. Would you be okay with leaving this off and requiring a list? |
Member
|
That is fine. |
Collaborator
Author
|
Thanks for the feedback. Updated. |
VisLab
approved these changes
Feb 11, 2020
satra
approved these changes
Feb 11, 2020
VisLab
approved these changes
Feb 12, 2020
sappelhoff
approved these changes
Feb 12, 2020
franklin-feingold
added a commit
that referenced
this pull request
Feb 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #379.