[FIX] Typos and clarifications#386
Merged
sappelhoff merged 3 commits intobids-standard:masterfrom Jan 13, 2020
apjanke:fix-typos-01
Merged
[FIX] Typos and clarifications#386sappelhoff merged 3 commits intobids-standard:masterfrom apjanke:fix-typos-01
sappelhoff merged 3 commits intobids-standard:masterfrom
apjanke:fix-typos-01
Conversation
apjanke
commented
Dec 21, 2019
| | NumberOfVolumesDiscardedByUser | RECOMMENDED. Number of volumes ("dummy scans") discarded by the user before including the file in the dataset. If possible, including all of the volumes is strongly recommended. Please note that the onsets recorded in the \_event.tsv file should always refer to the beginning of the acquisition of the first volume in the corresponding imaging file - independent of the value of `NumberOfVolumesDiscardedByUser` field. | | ||
| | DelayTime | RECOMMENDED. User specified time (in seconds) to delay the acquisition of data for the following volume. If the field is not present it is assumed to be set to zero. Corresponds to Siemens CSA header field `lDelayTimeInTR`. This field is REQUIRED for sparse sequences using the `RepetitionTime` field that do not have the `SliceTiming` field set to allowed for accurate calculation of "acquisition time". This field is mutually exclusive with `VolumeTiming`. | | ||
| | AcquisitionDuration | RECOMMENDED. Duration (in seconds) of volume acquisition. Corresponds to DICOM Tag 0018,9073 `Acquisition Duration`. This field is REQUIRED for sequences that are described with the `VolumeTiming` field and that not have the `SliceTiming` field set to allowed for accurate calculation of "acquisition time". This field is mutually exclusive with `RepetitionTime`. | | ||
| | AcquisitionDuration | RECOMMENDED. Duration (in seconds) of volume acquisition. Corresponds to DICOM Tag 0018,9073 `Acquisition Duration`. This field is REQUIRED for sequences that are described with the `VolumeTiming` field and that do not have the `SliceTiming` field set to allowed for accurate calculation of "acquisition time". This field is mutually exclusive with `RepetitionTime`. | |
Contributor
Author
There was a problem hiding this comment.
changed "and that not have" to "and that do not have"
sappelhoff
previously approved these changes
Jan 6, 2020
Member
sappelhoff
left a comment
There was a problem hiding this comment.
Thanks @apjanke these changes look good to me.
Have you considered adding yourself to the contributors list?
see: https://github.com/bids-standard/bids-specification/blob/master/src/99-appendices/01-contributors.md
If you want to, you can just do one additional commit here.
effigies
reviewed
Jan 7, 2020
Collaborator
effigies
left a comment
There was a problem hiding this comment.
Looks good. A couple fixes for the fixes.
Collaborator
|
The easiest way to add yourself as a contributor is to edit the Wiki page (https://github.com/bids-standard/bids-specification/wiki/Contributors). This will be merged in before any release. And to be clear, BIDS strongly encourages any level of engagement, so let me assure you that you have contributed enough to add yourself to the list. |
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Contributor
Author
|
LOL. Fixes for the fixes pulled in. And I've added myself to the Contributors wiki page. Thanks! |
effigies
approved these changes
Jan 7, 2020
sappelhoff
approved these changes
Jan 7, 2020
Member
|
Thanks @apjanke! |
franklin-feingold
added a commit
that referenced
this pull request
Jan 13, 2020
satra
added a commit
to satra/bids-specification
that referenced
this pull request
Feb 7, 2020
* upstream/master: (439 commits) [DOC] Auto-generate changelog entry for PR bids-standard#394 Update 01-contributors.md [DOC] Auto-generate changelog entry for PR bids-standard#389 [DOC] Auto-generate changelog entry for PR bids-standard#386 moved list of extension proposals to the main BIDS website section 06-extensions remains, but now points to the main website Typo fix for typo fix Typo fix for typo fix [DOC] Auto-generate changelog entry for PR bids-standard#374 [FIX] Fix some typos and prose style issues [DOC] Auto-generate changelog entry for PR bids-standard#383 restructure according to @emdupre's proposal neurostars for everything not just technical Apply suggestions from code review MNT: Update Pipfile ENH: Append CSS instead of overriding it ENH: Add watermark to drafts [DOC] Auto-generate changelog entry for PR bids-standard#381 Update src/06-extensions.md Retiring moderator duties for BEP021 [DOC] Auto-generate changelog entry for PR bids-standard#380 ...
satra
added a commit
to satra/bids-specification
that referenced
this pull request
Feb 7, 2020
* upstream/master: (439 commits) [DOC] Auto-generate changelog entry for PR bids-standard#394 Update 01-contributors.md [DOC] Auto-generate changelog entry for PR bids-standard#389 [DOC] Auto-generate changelog entry for PR bids-standard#386 moved list of extension proposals to the main BIDS website section 06-extensions remains, but now points to the main website Typo fix for typo fix Typo fix for typo fix [DOC] Auto-generate changelog entry for PR bids-standard#374 [FIX] Fix some typos and prose style issues [DOC] Auto-generate changelog entry for PR bids-standard#383 restructure according to @emdupre's proposal neurostars for everything not just technical Apply suggestions from code review MNT: Update Pipfile ENH: Append CSS instead of overriding it ENH: Add watermark to drafts [DOC] Auto-generate changelog entry for PR bids-standard#381 Update src/06-extensions.md Retiring moderator duties for BEP021 [DOC] Auto-generate changelog entry for PR bids-standard#380 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some suggested minor typo and style fixes.