[FIX] Number explicitly all cases in MRI field map section headers#323
Conversation
effigies
left a comment
There was a problem hiding this comment.
So case 4 was numbered and the other three weren't? Seems straightforward. I suspect that during the translation somebody accidentally interpreted the #### as automatically numbering.
|
@effigies That's right. |
|
Style failure: This is a bad requirement, IMO. I think we should probably add: to: Lines 1 to 9 in 4c39c10 |
Although excessively long headings should be avoided IMHO, the markup already requires a few characters, so I agree with what you propose. I would be for doing it in another PR, then rebasing this one. Is this change something that requires to be discussed by a larger part of the community or shall I push the change now? |
|
Sure, go ahead and open a PR to update the linter rules. It'll take two reviewers to merge. I don't think it's likely to be controversial. |
Done in #325. |
|
Can you go ahead and rebase this commit onto #325 in order to verify that it is the correct fix for this linting error? |
ff37735 to
5507c85
Compare
franklin-feingold
left a comment
There was a problem hiding this comment.
Thank you for catching this! May you please add your name to our contributors wiki to credit your contribution? For releases, we take our wiki and update our contributors appendix
|
You're very welcome @franklin-feingold ! I had already added my name to the contributors wiki ! |
|
OKay, this PR is now ready for a rebase @jhlegarreta :-) |
Number explicitly all cases in MRI field map section headers for the sake of consistency.
ba93922
5507c85 to
ba93922
Compare
|
ba93922 rebased on |
|
Thanks! BTW: I like the way you named your branch to make this PR 😉 |
|
The actual change is 7 days old, so I don't see a need to wait 5 days from the most recent commit in this case. Merging. |
Number explicitly all cases in MRI field map section headers for the
sake of consistency.