Skip to content

[FIX] repair link in anatomical MRI table#297

Merged
sappelhoff merged 3 commits intobids-standard:masterfrom
sappelhoff:fixlink
Aug 12, 2019
Merged

[FIX] repair link in anatomical MRI table#297
sappelhoff merged 3 commits intobids-standard:masterfrom
sappelhoff:fixlink

Conversation

@sappelhoff
Copy link
Copy Markdown
Member

@sappelhoff sappelhoff commented Aug 12, 2019

After the merge of the linkchecker, we found a broken link that now makes our CI red.

I am at a loss, why this was only caught after the merge of that PR, but anyhow - this should fix it.

@sappelhoff sappelhoff requested a review from chrisgorgo as a code owner August 12, 2019 15:22
@KirstieJane
Copy link
Copy Markdown
Member

KirstieJane commented Aug 12, 2019

The "broken" link works for me - is it perhaps because it is http rather than https?

@sappelhoff
Copy link
Copy Markdown
Member Author

sappelhoff commented Aug 12, 2019 •
edited
Loading

The "broken" link works for me - is it perhaps because it is http rather than https?

I think that perhaps it was just linkchecker experiencing a timeout? 🤔 because it seems that in this PR I am fixing a different URL than the one raised in the CI report.

It's somehow a lucky coincidence, because there WAS an error with the neighboring URL that was uncaught but is now fixed:

Before the change, notice how the URL text does not align with the actual link:

[http://www.ncbi.nlm.nih.gov/pmc/articles/PMC4346383/](http://www.ncbi.nlm.nih.gov/pubmed/24474423)

Now, they are congruent.

@KirstieJane
Copy link
Copy Markdown
Member

KirstieJane commented Aug 12, 2019

Gotcha! All fine (although it feels like replacing http with https is a good signal that we don't encourage insecure practices).

@KirstieJane KirstieJane self-requested a review August 12, 2019 15:50
KirstieJane
KirstieJane previously approved these changes Aug 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@KirstieJane KirstieJane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Thanks @sappelhoff ✨

KirstieJane
KirstieJane approved these changes Aug 12, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@KirstieJane KirstieJane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved! We can't put in secure pages if they don't exist 😅

@sappelhoff sappelhoff added this to the 1.2.1 milestone Aug 12, 2019
@franklin-feingold
Copy link
Copy Markdown
Collaborator

franklin-feingold commented Aug 12, 2019

LGTM! Thank you @sappelhoff - making our CI's happy :)

@sappelhoff sappelhoff merged commit 84a9a98 into bids-standard:master Aug 12, 2019
@sappelhoff sappelhoff deleted the fixlink branch August 12, 2019 20:03
franklin-feingold added a commit that referenced this pull request Aug 12, 2019
@franklin-feingold
[DOC] Auto-generate changelog entry for PR #297
be10961
@sappelhoff sappelhoff changed the title FIX: repair link in anatomical MRI table [FIX] repair link in anatomical MRI table May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@KirstieJane KirstieJane KirstieJane approved these changes

@franklin-feingold franklin-feingold franklin-feingold approved these changes

@chrisgorgo chrisgorgo Awaiting requested review from chrisgorgo

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

1.2.1

Development

Successfully merging this pull request may close these issues.

3 participants

@sappelhoff @KirstieJane @franklin-feingold