Skip to content

[MISC] Cleanup#29

Merged
chrisgorgo merged 9 commits intobids-standard:masterfrom
chrisgorgo:enh/cleanup
Oct 4, 2018
Merged

[MISC] Cleanup#29
chrisgorgo merged 9 commits intobids-standard:masterfrom
chrisgorgo:enh/cleanup

Conversation

@chrisgorgo
Copy link
Copy Markdown
Contributor

@chrisgorgo chrisgorgo requested a review from teonbrooks October 4, 2018 01:23
@@ -1,97 +1,9 @@
Magnetic Resonance Imaging data
-------------------------------
# Magnetic Resonance Imaging data
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this also applies to the MEG section below. Since this is listed as a subheading (h2) under the Modality Specific Files heading (existed only at the folder level right now), should this be marked as an h1 here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That throws off mkdocs (might be the same effect on mdbook):

with ## Behavioral experiments (with no MRI)
image

with # Behavioral experiments (with no MRI)
image

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok cool. that works. resolved

@@ -1,5 +1,4 @@
Appendix I: Contributors
------------------------
# Appendix I: Contributors
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question about the nested folder structure

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

resolved above

@@ -1,5 +1,4 @@
Appendix  VI: MEG file formats
------------------------------
# Appendix  VI: MEG file formats
Copy link
Copy Markdown
Collaborator

@teonbrooks teonbrooks Oct 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

currently there are two spaces between Appendix and VI

@teonbrooks
Copy link
Copy Markdown
Collaborator

lgtm, just one nitpick of space here #29 (comment).

after you rebase and you include the updated license info from #31, feel free to merge

@chrisgorgo chrisgorgo merged commit d967a33 into bids-standard:master Oct 4, 2018
@teonbrooks
Copy link
Copy Markdown
Collaborator

thanks @chrisfilo!

effigies pushed a commit that referenced this pull request Sep 18, 2019
@sappelhoff sappelhoff changed the title Cleanup [MISC] Cleanup Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants