Merged
Conversation
Contributor
chrisgorgo
commented
Oct 3, 2018
- adding sections that were left out from [MISC] split intro, commons, mr, and meg into directory from specification.md #28
- harmonizing how headers are handled
- removing header status from Examples
- removing the redundant big file
teonbrooks
reviewed
Oct 4, 2018
| @@ -1,97 +1,9 @@ | |||
| Magnetic Resonance Imaging data | |||
| ------------------------------- | |||
| # Magnetic Resonance Imaging data | |||
Collaborator
There was a problem hiding this comment.
this also applies to the MEG section below. Since this is listed as a subheading (h2) under the Modality Specific Files heading (existed only at the folder level right now), should this be marked as an h1 here?
Contributor
Author
Collaborator
There was a problem hiding this comment.
ok cool. that works. resolved
| @@ -1,5 +1,4 @@ | |||
| Appendix I: Contributors | |||
| ------------------------ | |||
| # Appendix I: Contributors | |||
Collaborator
There was a problem hiding this comment.
same question about the nested folder structure
| @@ -1,5 +1,4 @@ | |||
| Appendix VI: MEG file formats | |||
| ------------------------------ | |||
| # Appendix VI: MEG file formats | |||
Collaborator
There was a problem hiding this comment.
currently there are two spaces between Appendix and VI
Collaborator
|
lgtm, just one nitpick of space here #29 (comment). after you rebase and you include the updated license info from #31, feel free to merge |
Collaborator
|
thanks @chrisfilo! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

