Skip to content

[ENH] BEP Update#277

Merged
sappelhoff merged 17 commits intobids-standard:masterfrom
franklin-feingold:enh/bepupdate
Aug 14, 2019
Merged

[ENH] BEP Update#277
sappelhoff merged 17 commits intobids-standard:masterfrom
franklin-feingold:enh/bepupdate

Conversation

@franklin-feingold
Copy link
Copy Markdown
Collaborator

@franklin-feingold franklin-feingold commented Jul 18, 2019

This provides an update for each of our BEP projects. Included is a status summary and potential blocking point(s). Here is the rendering.

@bids-standard/bep_leads - if you may please review your BEP summary and provide suggestions or enhancements if needed. Thank you!

One change is bringing back BEP012, 013, 016 into the extensions table because they were split from the common derivatives (#254)

@DejanDraschkow
Copy link
Copy Markdown

looks good for bep020

sappelhoff
sappelhoff previously approved these changes Jul 19, 2019
Copy link
Copy Markdown
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the formatting and I think that this is a good addition to be updated 3 times a year :-)

@sappelhoff sappelhoff added this to the 1.2.1 milestone Jul 22, 2019
Co-Authored-By: Oscar Esteban <code@oscaresteban.es>
sappelhoff
sappelhoff previously approved these changes Jul 23, 2019
@effigies
Copy link
Copy Markdown
Collaborator

This looks like it's reverted almost all of its changes...

@franklin-feingold
Copy link
Copy Markdown
Collaborator Author

franklin-feingold commented Jul 23, 2019

darn! will revert back to the edited version (f8da9f6) but with Travis happy

Edit: have brought back the updated BEP table

@sappelhoff
Copy link
Copy Markdown
Member

This looks like it's reverted almost all of its changes...

thanks for catching that Chris! 😬

@franklin-feingold
Copy link
Copy Markdown
Collaborator Author

reverted BEP018 back to the active list. Prepared this PR for a patch release. Can be updated when BEP018 is merged in for a minor release.

pinging @effigies @sappelhoff for review - here is current rendering

| [BEP009](https://docs.google.com/document/d/1mqMLnxVdLwZjDd4ZiWFqjEAmOmfcModA_R535v3eQs0) | Positron Emission Tomography (PET) | Melanie Ganz | Very close to completion. This includes finalizing the standard and writing the paper. | None. |
| [BEP011](https://docs.google.com/document/d/1YG2g4UkEio4t_STIBOqYOwneLEs1emHIXbGKynx7V0Y) | The structural preprocessing derivatives | Andrew Hoopes | Have finalized the surface-based and volumetric overlays (and stats), differentiate between discrete and probabilistic segmentation. The next step for this BEP is standardizing the universal look-up table and characterizing surfaces. | None. |
| [BEP012](https://docs.google.com/document/d/16CvBwVMAs0IMhdoKmlmcm3W8254dQmNARo-7HhE-lJU) | The functional preprocessing derivatives | Camille Maumet and Chris Markiewicz | | None. |
| [BEP013](https://docs.google.com/document/d/1qBNQimDx6CuvHjbDvuFyBIrf2WRFUOJ-u50canWjjaw) | The resting state fMRI derivatives | Steven Giavasis | | None. |
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one was merged into BEP012.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a note of this for this update. In future updates it can be noted below the merged BEPs (e.g. BEP 6, 7, 8, 10)

@franklin-feingold franklin-feingold mentioned this pull request Aug 2, 2019
4 tasks
@sappelhoff
Copy link
Copy Markdown
Member

looks fine to me

@sappelhoff
Copy link
Copy Markdown
Member

@franklin-feingold are you ready to have this one merged?

Co-Authored-By: Kirstie Whitaker <kw401@cam.ac.uk>
@franklin-feingold
Copy link
Copy Markdown
Collaborator Author

should be ready to merge - will commit a fix for travis

@franklin-feingold
Copy link
Copy Markdown
Collaborator Author

cc @sappelhoff @effigies should be ready to merge

@sappelhoff sappelhoff merged commit 252c8d6 into bids-standard:master Aug 14, 2019
@sappelhoff
Copy link
Copy Markdown
Member

Thanks @franklin-feingold

@franklin-feingold franklin-feingold deleted the enh/bepupdate branch August 14, 2019 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants