[ENH] adding release guidelines#267
Conversation
sappelhoff
left a comment
There was a problem hiding this comment.
Thanks @franklin-feingold! I made several wording changes. Perhaps you can commit them as a batch to avoid lots of commits.
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
emdupre
left a comment
There was a problem hiding this comment.
Thanks again, @franklin-feingold ✨ A few small suggestions / clarifications below 👇
effigies
left a comment
There was a problem hiding this comment.
Thanks for putting this together Franklin. I've added some suggestions that I hope will help clarify, taking into account Stefan and Elizabeth's comments.
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
sappelhoff
left a comment
There was a problem hiding this comment.
looks great! Just two nitpicks from my side
Co-Authored-By: Stefan Appelhoff <stefan.appelhoff@mailbox.org> Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
sappelhoff
left a comment
There was a problem hiding this comment.
I approve :-)
and once this is in, I think we should focus on actually doing a patch release!
|
Oh, sure. Sorry, let me look... |
effigies
left a comment
There was a problem hiding this comment.
One small change, but otherwise I'm happy with this.
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
|
merged! Thanks @franklin-feingold for the PR and everybody else for reviewing |
addresses #257 and converted from this google doc
This is in the review phase and comment phase. I thought it could perhaps be easier to work and wrap up in this PR.