The favicon does not seem to work yet ... But I think through #250 I got an idea how to solve it (place the favicon in /theme_customizations and point to it from mkdocs.yml)

This PR can still be merged after the potential enhancement through Franklin's provision of the cropped file (see original post)

Thank you for looking into this! Opened a PR (https://github.com/sappelhoff/bids-specification/pull/10) to add the crop and remove the not-cropped white logo.

Regarding the favicon enhancement - the theme we are using to render the readthedocs (material) provided a very short summary of how to customize the favicon (https://squidfunk.github.io/mkdocs-material/getting-started/#favicon). I also looked at another repo that did successfully (https://github.com/opensciencegrid/technology/blob/master/mkdocs.yml), interesting that removing the spaces didn't render it.

Regarding the favicon enhancement - the theme we are using to render the readthedocs (material) provided a very short summary of how to customize the favicon (https://squidfunk.github.io/mkdocs-material/getting-started/#favicon). I also looked at another repo that did successfully (https://github.com/opensciencegrid/technology/blob/master/mkdocs.yml), interesting that removing the spaces didn't render it.

yes, the image is on the wrong path ... we expect Mkdocs-material to be searching for 'BIDS_logo/favicon.ico' from the root of our repository ./ ... but it's using some other path 🤷‍♂

Once this PR is merged, I can rebase #250 and put the icon into the /theme_customizations directory under a path assets/images/favicon --> then it will replace the mkdocs-material default (see here)

that sounds good! has your fork rendered the favicon in the new path?

that sounds good! has your fork rendered the favicon in the new path?

I didn't try it yet, waiting for #250 to be merged first :-)

okay, so the favicon works:

rendered: https://720-150465237-gh.circle-artifacts.com/0/home/circleci/project/site/index.html

appears something with this merge failed circle - https://circleci.com/gh/bids-standard/bids-specification/722

I assume it's a temporary issue having to do with a server response / internet connection:

This is the error:

/usr/local/bundle/gems/octokit-4.9.0/lib/octokit/response/raise_error.rb:16:in `on_complete': GET https://api.github.com/repos/bids-standard/bids-specification/issues/137/events?per_page=100: 502 - Server Error (Octokit::BadGateway)

I restarted the build, and now it passes: https://circleci.com/workflow-run/57dbb9e8-49e5-4f9d-a5d6-9f7b75cd9e5e

interesting - our badge is still failing, not sure why

takes some time to update, I guess :-)

all green now: