Skip to content

[MISC] updating MEG doc links, manufacturer names, and adding a missing MEG example#248

Merged
sappelhoff merged 4 commits intobids-standard:masterfrom
sappelhoff:fixlinks
Jun 28, 2019
Merged

[MISC] updating MEG doc links, manufacturer names, and adding a missing MEG example#248
sappelhoff merged 4 commits intobids-standard:masterfrom
sappelhoff:fixlinks

Conversation

@sappelhoff
Copy link
Copy Markdown
Member

@sappelhoff sappelhoff commented Jun 21, 2019

closes #253

this PR started out by fixing some old Google Docs links to point to the current specification ... now I am also adding a missing example for KRISS MEG data and correcting/expanding some MEG manufacturer names

@sappelhoff sappelhoff requested a review from monkeyman192 as a code owner June 21, 2019 10:55
@sappelhoff sappelhoff force-pushed the fixlinks branch 2 times, most recently from eaf7be9 to 7071dd5 Compare June 21, 2019 11:02
Copy link
Copy Markdown
Collaborator

@teonbrooks teonbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just one suggestion. other than that, lgtm

- [`ITAB`](https://docs.google.com/document/d/1FWex_kSPWVh_f4rKgd5rxJmxlboAPtQlmBc1gyZlRZM/edit#heading=h.58whib3oq56y)
- `Aalto/MEG–MRI`
- [`CTF`](06-meg-file-formats.md#ctf)
- [`Elekta/Neuromag`](06-meg-file-formats.md#neuromagelektamegin)
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would include Megin here: [Elekta/Neuromag/Megin]

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then keep the order historically consistent, i.e. Neuromag/Elekta/Megin, or the other way around. For FieldTrip I decided to converge on old/newer/current.

See also http://www.fieldtriptoolbox.org/getting_started/ctf/, http://www.fieldtriptoolbox.org/getting_started/bti/, http://www.fieldtriptoolbox.org/getting_started/neuromag/, to which I just added a short "historical" section at the top.

Copy link
Copy Markdown
Member Author

@sappelhoff sappelhoff Jun 25, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, I really like these historical sections ... they are important for new people to understand what all of these names are about :-)

Now that we are fixing names, what about KIT/Yokogawa/Ricoh? ... in the FT wiki, there are separate pages for:

yet they are combined here in the BIDS spec. Also: I cannot find an entry for KIT in the FT wiki

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @robertoostenveld, in case you missed my question

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@KiwamuK, the Ricoh engineer that currently maintains the support for their system in FieldTrip, preferred to keep the two website pages separate. Afaik the file formats are still the same, hence I propose to specify it as KIT/Yokogawa/Ricoh, in line with the others. I do not have information about the MEG system prior to Yokogawa being involved.

@sappelhoff sappelhoff changed the title [MISC] redirect links for MEG systems from googledoc to spec [MISC] updating MEG doc links, manufacturer names, and adding a missing MEG example Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KRISS MEG data question

3 participants