[FIX] Clarify Appendix II: The list of licenses only lists examples#222
Merged
sappelhoff merged 2 commits intobids-standard:masterfrom May 17, 2019
Merged
[FIX] Clarify Appendix II: The list of licenses only lists examples#222sappelhoff merged 2 commits intobids-standard:masterfrom
sappelhoff merged 2 commits intobids-standard:masterfrom
Conversation
rwblair
previously approved these changes
May 9, 2019
effigies
reviewed
May 9, 2019
Collaborator
effigies
left a comment
There was a problem hiding this comment.
I'm a little inclined to acknowledge the reasons that people might need to use more restrictive licenses. The current phrasing reads as a little flippant.
Here's a suggestion:
Co-Authored-By: Chris Markiewicz <effigies@gmail.com>
Member
Author
|
Thanks @effigies, that makes it much clearer. |
effigies
approved these changes
May 9, 2019
rwblair
approved these changes
May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #218