Skip to content

[FIX] Trivial column header fix #220

Merged
effigies merged 3 commits intobids-standard:masterfrom
nicholst:TrivialHeaderFix
May 9, 2019
Merged

[FIX] Trivial column header fix #220
effigies merged 3 commits intobids-standard:masterfrom
nicholst:TrivialHeaderFix

Conversation

@nicholst
Copy link
Copy Markdown
Collaborator

@nicholst nicholst commented May 6, 2019

Replace underscore-separated column headers with capitalised, space-separated headers.

Just fixing some snake-case formatted column labels (modality_label & contrast_label).

@nicholst nicholst requested a review from chrisgorgo as a code owner May 6, 2019 15:03
@nicholst
Copy link
Copy Markdown
Collaborator Author

nicholst commented May 6, 2019

If matching the original label string was intentional, then I'd recommend making it 'code' text, as in modality_label instead of modality_label and contrast_label instead of contrast_label.

chrisgorgo
chrisgorgo suggested changes May 6, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@chrisgorgo chrisgorgo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not a typo. Those names correspond verbatim to a placeholder name in respective file name templates. Maybe adding brackets to the header name would make it more clear.

@chrisgorgo
Copy link
Copy Markdown
Contributor

chrisgorgo commented May 6, 2019

If matching the original label string was intentional, then I'd recommend making it 'code' text, as in modality_label instead of modality_label and contrast_label instead of contrast_label.

Sounds good to me.

@nicholst
Copy link
Copy Markdown
Collaborator Author

nicholst commented May 6, 2019

Done! Now just changes the font.

@chrisgorgo
Copy link
Copy Markdown
Contributor

chrisgorgo commented May 7, 2019

Thanks! I think you need to fix the table width now. See https://travis-ci.com/bids-standard/bids-specification/builds/110783874#L481 and https://github.com/bids-standard/bids-specification/blob/master/CONTRIBUTING.md#writing-in-markdown

chrisgorgo
chrisgorgo previously approved these changes May 7, 2019
View reviewed changes
@nicholst
Copy link
Copy Markdown
Collaborator Author

nicholst commented May 7, 2019

Lint should be happy now.

@effigies effigies merged commit 07a8965 into bids-standard:master May 9, 2019
franklin-feingold added a commit that referenced this pull request May 9, 2019
@franklin-feingold
[DOC] Auto-generate changelog entry for PR #220
2c2f829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sappelhoff sappelhoff sappelhoff approved these changes

+1 more reviewer

@chrisgorgo chrisgorgo chrisgorgo approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nicholst @chrisgorgo @sappelhoff @effigies