[INFRA] Enable permalink urls to appear at (sub)section headings#214
Merged
yarikoptic merged 2 commits intobids-standard:masterfrom Apr 29, 2019
Merged
[INFRA] Enable permalink urls to appear at (sub)section headings#214yarikoptic merged 2 commits intobids-standard:masterfrom
yarikoptic merged 2 commits intobids-standard:masterfrom
Conversation
There is no convenient way to obtain a permalink to reference a specific (sub)section in the page ATM. Only top level section urls available in the TOC. With this permalink those IDs, which are already in HTML anyways, become exposed so it is easy to get permalink for any section. I chose # symbol since that is what is used in the URL to separate out the fragment to point to that ID in the page
Collaborator
|
I've often seen the paragraph symbol (¶) for this purpose, but I don't know that it's any more meaningful. Is there any way to just make the header text itself the link? That would be most intuitive to me. |
Collaborator
|
But to be clear, I am very supportive of this move and have felt the lack of these links in any text. |
Member
|
Thanks @yarikoptic +1 for this PR. Like @effigies I would prefer if the header text could be the link. |
Co-Authored-By: yarikoptic <debian@onerussian.com>
sappelhoff
approved these changes
Apr 28, 2019
Collaborator
Author
|
Looks great! Thanks! |
franklin-feingold
added a commit
that referenced
this pull request
Apr 29, 2019
Collaborator
Author
|
where could I find the current master build of the spec? I guess the one on https://bids-specification.readthedocs.io is the released one so doesn't have anchors yet |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no convenient way to obtain a permalink to reference a specific (sub)section
in the page ATM. Only top level section urls available in the TOC. With this permalink
those IDs, which are already in HTML anyways, become exposed so it is easy to get
permalink for any section. I chose # symbol since that is what is used in the URL to
separate out the fragment to point to that ID in the page, e.g.