[SCHEMA] Allow physio files for anat datatype#1961
Merged
effigies merged 5 commits intobids-standard:masterfrom Oct 17, 2024
Merged
[SCHEMA] Allow physio files for anat datatype#1961effigies merged 5 commits intobids-standard:masterfrom
effigies merged 5 commits intobids-standard:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1961 +/- ##
=======================================
Coverage 86.87% 86.87%
=======================================
Files 16 16
Lines 1410 1410
=======================================
Hits 1225 1225
Misses 185 185 ☔ View full report in Codecov by Sentry. |
effigies
reviewed
Oct 17, 2024
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
Co-authored-by: Chris Markiewicz <effigies@gmail.com>
effigies
reviewed
Oct 17, 2024
effigies
approved these changes
Oct 17, 2024
Collaborator
|
Implements a change agreed upon in #513. |
effigies
added a commit
to bids-standard/legacy-validator
that referenced
this pull request
Oct 21, 2024
yarikoptic
added a commit
to yarikoptic/bids-specification
that referenced
this pull request
Oct 28, 2024
…ttype * commit 'v1.10.0-35-g5f7004819': (218 commits) Include entity-less "scans.json" into an example of inheritance principle (bids-standard#1945) fix(checks): Enforce timing mutual exclusions on BOLD/ASL data only (bids-standard#1969) refactor contributing (bids-standard#1965) [pre-commit.ci] pre-commit autoupdate (bids-standard#1967) [SCHEMA] Allow physio files for anat datatype (bids-standard#1961) [pre-commit.ci] pre-commit autoupdate Add an empty line in hope to get table rendered properly in "Ordering rules" section (bids-standard#1953) schema: add check for duplicate READMEs (bids-standard#1952) [MAINT] switch bidsschematools to pyproject.toml (bids-standard#1948) fix(schema): Disable TaskName check for channels and markers files Permit and warn on task/acquisition/run for electrodes and coordsystems [FIX] Allow (but discourage) task entity for coordsystem.json fix(schema): Limit MRI metadata checks to NIfTIs fix: Only check for sorted times in arrays py3.13 (bids-standard#1947) [pre-commit.ci] pre-commit autoupdate (bids-standard#1946) [FIX] Update changelog links to avoid redirects (bids-standard#1944) [ENH] Update DWI suffixes to include most common scanner derivatives (bids-standard#1864) [pre-commit.ci] pre-commit autoupdate [MAINT] Update Release_Protocol.md ...
effigies
added a commit
that referenced
this pull request
Dec 5, 2024
* add anat to datatypes field for timeseries no task in schema/rules/files/raw/task * Update src/schema/rules/files/raw/task.yaml Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Update src/schema/rules/files/raw/task.yaml Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Update src/schema/rules/files/raw/task.yaml Co-authored-by: Chris Markiewicz <effigies@gmail.com> * Update src/schema/rules/files/raw/task.yaml --------- Co-authored-by: Chris Markiewicz <effigies@gmail.com>
yarikoptic
added a commit
that referenced
this pull request
Dec 18, 2024
* origin/master: (26 commits) Update tools/schemacode/src/bidsschematools/types/namespace.py fail build on macro fails graceful error when failing to load invalid yml fix Update mkdocs.yml fix more seg Update src/modality-specific-files/electroencephalography.md fix channel, elec, sim recording fix key value and in-out fix tabular and seg reset fix internal links enh: Link all DICOM tags following standard pattern chore(links): Fix http -> https 301 redirects Update Release_Protocol.md (#1997) schema-1.0.1-dev schema-1.0.0 [SCHEMA] Allow physio files for anat datatype (#1961) FIX: Add 1.10.0 to known versions list (#1994) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue outlined in bids-standard/bids-validator#2164
This would fail to cover echo, part, and chunk entities which are legal for anatomical images and so too would be legal in the physio filenames.