[INFRA] Fix internal links implicitly#1096
Conversation
sappelhoff
left a comment
There was a problem hiding this comment.
Thanks @effigies I like this solution. Looks like black magic to me, but why not 😏
Codecov Report
@@ Coverage Diff @@
## master #1096 +/- ##
==========================================
+ Coverage 70.53% 71.71% +1.18%
==========================================
Files 9 9
Lines 930 937 +7
==========================================
+ Hits 656 672 +16
+ Misses 274 265 -9
Continue to review full report at Codecov.
|
add test try new method REPLACEME -> PATH_TO_SRC remove first attempt add relpaths make_columns_table use PATH_TO_SRC in columns.yaml html -> md add relpath arg for glossary fix tests add relpath for suffix tables add relpath for metadata add tests run black PATH_TO_SRC -> SPEC_ROOT fix param ordering consistency '..'|'.' -> page.file relpath -> page_file detect relpath from page.file fix docstrings fix tests run black fix PDF build MNT: Restore sources Revert test_render changes
|
@sappelhoff I squashed all your changes and my reversions of some changes into a single commit so that it would be easy to rebase and limit the amount of history devoted to experimentation. Let me know if you prefer to keep your history. |
sappelhoff
left a comment
There was a problem hiding this comment.
Great, thanks a lot @effigies.
To avoid some boilerplate, I wanted to see if we could get away with fixing linking without modifying the macro calls at all, from the spec side.
Patch on top of #1056. Might just be a bad idea, but I want to see if it builds.