[FIX] IntendedFor in (i)EEG is dataset relative#1093
Merged
sappelhoff merged 3 commits intobids-standard:masterfrom May 2, 2022
Merged
[FIX] IntendedFor in (i)EEG is dataset relative#1093sappelhoff merged 3 commits intobids-standard:masterfrom
sappelhoff merged 3 commits intobids-standard:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
+ Coverage 70.75% 71.71% +0.96%
==========================================
Files 9 9
Lines 937 937
==========================================
+ Hits 663 672 +9
+ Misses 274 265 -9 ☔ View full report in Codecov by Sentry. |
sappelhoff
commented
Apr 26, 2022
Member
Author
sappelhoff
left a comment
There was a problem hiding this comment.
@tsalo is the way I deal with the schema here fine?
This was referenced Apr 26, 2022
Member
|
It looks good to me. I would have recommended |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.