[MISC] consistently use "directory" instead of "folder" as a term#1044
Merged
sappelhoff merged 4 commits intobids-standard:masterfrom Apr 4, 2022
Merged
[MISC] consistently use "directory" instead of "folder" as a term#1044sappelhoff merged 4 commits intobids-standard:masterfrom
sappelhoff merged 4 commits intobids-standard:masterfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1044 +/- ##
==========================================
+ Coverage 70.53% 71.50% +0.96%
==========================================
Files 9 9
Lines 930 930
==========================================
+ Hits 656 665 +9
+ Misses 274 265 -9 ☔ View full report in Codecov by Sentry. |
Collaborator
|
+1 on consistency! |
effigies
reviewed
Mar 30, 2022
effigies
approved these changes
Mar 30, 2022
Collaborator
effigies
left a comment
There was a problem hiding this comment.
Looks good modulo preceding comment.
Remi-Gau
approved these changes
Mar 30, 2022
Lestropie
added a commit
to Lestropie/bids-specification
that referenced
this pull request
Apr 29, 2022
Resolves bids-standard#947 against: - bids-standard#962 (21b7725) - bids-standard#1044 (d9eeb6d) - bids-standard#867 (5fe26e1) - bids-standard#998 (e47283a) Conflicts: src/02-common-principles.md src/schema/README.md src/schema/objects/entities.yaml src/schema/objects/metadata.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1039
Ideally we would add a CI step that checks for the
[fF]older[s]{0,1}regex.