[WIP] merge bep006_eeg branch into master #95
[WIP] merge bep006_eeg branch into master #95robertoostenveld wants to merge 98 commits intomasterfrom
Conversation
… Tracy Brandmeyer
include EEG example dataset
use "name" and "description" for the columns containing A1 and Fp1 etc.
Data set (empty) from a single subject recording.
Adding empty example data set to EEG branch
fix missing column in participants.tsv
Merge master into bep006
FIX #66 - made a clean version of the EEG-only branch
update bep006_eeg to synchronize with master
I have convertered the original data to EDF (at least pretended to convert it, since I don't have the data). I added the sidecar files. I am not sure whether it is now correct, I suspect there are things missing, but it should be much closer to a BIDS dataset now.
eeg example "rest" added
|
I suggest that we do not include --> --> We'll then end up with having three full datasets:
Opinions @CPernet @robertoostenveld ? |
|
sleep incomplete so yes we can discard
eeg_ds000117 has multiple runs and this is the only one like this in the set so I'd keep it
there was also a CB (cuba resting sate) dataset I pushed, and Robert cleaned it up - where is it?
…--
Dr Cyril Pernet,
Senior Academic Fellow, Neuroimaging Sciences
The University of Edinburgh
Centre for Clinical Brain Sciences (CCBS)
Chancellor's Building, Room GU426D
49 Little France Crescent
Edinburgh EH16 4SB
cyril.pernet@ed.ac.uk<mailto:cyril.pernet@ed.ac.uk>
tel: +44(0)131 465 9530
<http://www.sbirc.ed.ac.uk/cyril>http://www.sbirc.ed.ac.uk/cyril
http://www.ed.ac.uk/edinburgh-imaging
________________________________
From: Stefan Appelhoff <notifications@github.com>
Sent: 04 October 2018 19:09
To: bids-standard/bids-examples
Cc: PERNET Cyril; Mention
Subject: Re: [bids-standard/bids-examples] [WIP] merge bep006_eeg branch into master (#95)
I suggest that we do not include eeg_sleep and eeg_ds000117 with the EEG examples (i.e., delete them before merging this branch)
--> eeg_sleep is incomplete and is not being updated - furthermore there will be no "complete" data to back it up
--> eeg_ds000117 is a fork of the already existing ds000117 and does not really showcase something new.
________________________________
We'll then end up with having three full datasets:
* eeg_matchingpennies
* eeg_rishikesh
* eeg_rest-fmri
Opinions @CPernet<https://github.com/CPernet> @robertoostenveld<https://github.com/robertoostenveld> ?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#95 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AEjUDm4wd0vIXoNL1RzZjrYlyCrjDx27ks5uhk7cgaJpZM4UTLTZ>.
The University of Edinburgh is a charitable body, registered in
Scotland, with registration number SC005336.
|
|
@robertoostenveld do you know more about the "cuba resting state" dataset? And apart from that, are you +1 on removing the incomplete sleep example until @ChristophePhillips finds the time to contribute a complete dataset? |
[MRG] Remove sleep
[WIP] bring matchingpennies up to date with spec
* software filter added * added cuban dataset * no cbdata
* software filter added * added cuban dataset * no cbdata * cuban data added * updated *scans.tsv * added participants.json * age in years
|
looking very good! We only have I suggest using a squash and merge approach, so that we create a single commit out of all these changes. There was a lot of to and fro in the commit history that we should not pollute the master branch with. |
Co-authored-by: Arnaud Delorme <arnodelorme@gmail.com>
|
I recall that there was a "cuba resting state" dataset, but don't really know more about. I think the problem was that nobody currently involved really knows enough details for a good conversion. I think we are better off (initially) with a few sound examples, rather than with many sloppy ones. We can always extend/improve the examples later (not the ones that are mentioned in the paper, which are important right from the start). |
|
Oh, the Cuban dataset is "eeg_cbm" in the bep006_eeg branch. Looks clean enough to me for inclusion. +1 for leaving the sleep dataset from @ChristophePhillips out. |
|
I am closing this one in favor of #149, which is the rebased version of this PR. I think that is necessary because of two reasons:
The contents are exactly the same |
closes #132
This PR serves to initiate the final stages in the EEG example development. The bep006_eeg branch has some examples that all seem to pass the bids-validator (i.e. the eeg version of it).
This branch should NOT yet be merged as is, because the travis.yml needs to be updated to ensure that it points to the right validator. But creating this PR should hopefully show that the examples are properly aligned.