Skip to content

Update ReferencesAndLinks for array of strings requirement.#70

Merged
chrisgorgo merged 1 commit intobids-standard:masterfrom
nellh:master
Mar 27, 2018
Merged

Update ReferencesAndLinks for array of strings requirement.#70
chrisgorgo merged 1 commit intobids-standard:masterfrom
nellh:master

Conversation

@nellh
Copy link
Copy Markdown
Member

@nellh nellh commented Mar 27, 2018

This updates all dataset_description.json files to consistently use an array of strings for ReferencesAndLinks.

@jasmainak
Copy link
Copy Markdown
Collaborator

shouldn't this be tested in the validator?

@nellh
Copy link
Copy Markdown
Member Author

nellh commented Mar 27, 2018

Yes, this PR updates these examples so the validator tests will pass for these datasets after adding this to validation.

One other thing to note, I did split some \n\n delimited references up into separate array elements in three datasets: ds102, ds105, and ds113b. I left in single newlines.

@jasmainak
Copy link
Copy Markdown
Collaborator

yep that looks good and I saw your PR on the validator repo too :-)

@chrisgorgo
Copy link
Copy Markdown
Contributor

Perfect! Thanks! I'll merge and create a new release.

@chrisgorgo chrisgorgo merged commit 57a98fc into bids-standard:master Mar 27, 2018
sappelhoff pushed a commit that referenced this pull request May 12, 2019
Update ReferencesAndLinks for array of strings requirement.

Former-commit-id: 57a98fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants